Python Apps - Terminal size can interfere with URL matching

[jonvanausdeln]

System details:

Positron and OS details:

Current main branch
Windows (but probably not a windows only issue)

Interpreter details:

Python 3.12.1

Describe the issue:

When running smoke tests on windows, the screen can be small enough that when the URL is off screen, the Run App URL matching gets confused.

@sharon-wang has some insight to provide context

Steps to reproduce the issue:

1. Run the Python Apps test on windows CI

Test fails as the app is not displayed in Viewer.

Expected or desired behavior:

Test to pass

Were there any error messages in the UI, Output panel, or Developer Tools console?

[sharon-wang]

I believe the new URL() call here is the one that's failing. My hunch is that the URL was not correctly parsed from the Terminal because the URL appears on two lines, but it's hard to say without logging out what exactly got matched. It's also possible that we returned the wrong match group, but were able to detect the URL in the Terminal output.

positron/extensions/positron-run-app/src/api.ts

Lines 402 to 413 in c6b91c2

	// Check if the app url is found in the terminal output.
	if (!appUrl) {
	const match = extractAppUrlFromString(dataCleaned, options.appUrlStrings);
	if (match) {
	appUrl = new URL(match);
	log.debug(`Found app URL in terminal output: ${appUrl.toString()}`);
	// If the app is ready, we're done!
	if (appReady) {
	return appUrl;
	}
	}
	}

Some things we can try:

• add log.debug(`Matched URL in terminal output: ${match}`); right after if (match) so we can see what string was matched before trying to construct a url
  • it's possible that the match group was incorrect and we matched a different part of the terminal output instead of the URL
• if the size of the Terminal is the culprit here, we should still be able to parse out the URL. We may need to keep a buffer/string of all terminal output and check if the URL can be found in the full output as opposed to checking against the most recent data in the terminal output stream

[seeM]

We may need to keep a buffer/string of all terminal output and check if the URL can be found in the full output as opposed to checking against the most recent data in the terminal output stream

@sharon-wang In case it's helpful, I did notice while initially working on Python app support that terminal shell integration sometimes unexpectedly created a new "execution", so suspect your suggestion is the way to go.