Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Disconnected from extension host" in Console is confusing #5444

Open
jmcphers opened this issue Nov 21, 2024 · 0 comments
Open

"Disconnected from extension host" in Console is confusing #5444

jmcphers opened this issue Nov 21, 2024 · 0 comments
Labels
area: console Issues related to Console category.

Comments

@jmcphers
Copy link
Collaborator

System details:

Positron and OS details:

Positron Version: 2024.12.0 (Universal) build 41
Code - OSS Version: 1.93.0
Commit: 39536c265d6828a68291984d0d359170316d055e
Date: 2024-11-18T02:47:29.611Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Darwin arm64 23.6.0

Interpreter details:

Any

Describe the issue:

When the extension host is restarted, the message in the Console is technically correct but not very useful or helpful.

Image

End users probably do not know what the "Extension host" is or why it's shutting down or in general What Just Happened.

Steps to reproduce the issue:

  1. Disable an extension, e.g. vscode-vim
  2. The button changes from "Disable" to "Restart extensions". Press this button.

Image

The extension host restarts, and the Console emits the messages above.

Expected or desired behavior:

When the Extension Host is offline, we can't send or receive anything from the interpreter, so it does need to be communicated to the user in some way that "you can't run code right now". One way we could do this:

  • When the restart begins, replace the prompt with a spinner that says "Extensions restarting..."
  • When the restart completes, restore the prompt
@jmcphers jmcphers added the area: console Issues related to Console category. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: console Issues related to Console category.
Projects
None yet
Development

No branches or pull requests

1 participant