Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain editor tab order and active tab when restoring Data Explorer editors #5489

Open
sharon-wang opened this issue Nov 25, 2024 · 0 comments
Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request usability
Milestone

Comments

@sharon-wang
Copy link
Member

sharon-wang commented Nov 25, 2024

Describe the issue:

#5475 implemented the restoring of Data Explorer tabs upon reloading the IDE for #3172. However, the Data Explorer tabs are restored after any code editors are restored and tab order is not tracked, which can cause the editor tab ordering to change.

Steps to reproduce the issue:

  1. Start an interpreter, e.g. R 4.4.0
  2. View at least one data frame in the Data Explorer, e.g. View(iris)
  3. Open a code file and organize the editor tabs such that the Data Explorer tabs are not all at the end. Also note that the active tab is the code file.
    • e.g., Image
  4. Reload the IDE, e.g. Developer: Reload Window command in the Command Prompt (See Persisting UI state on session reload #5462 for more ways to reload)
  5. See that the Data Explorer tab(s) have been restored to the end of the tabs and that the active tab is the last Data Explorer tab
    • e.g., Image

Expected or desired behavior:

The tab order before reloading the IDE should be preserved, and a reopened Data Explorer tab should not become the active tab if another editor were previously the active tab.

From #5475 (review)

some changes in the data explorer service itself (to mark these tabs as custom editors that can be restored?) are needed for a better UX.

Were there any error messages in the UI, Output panel, or Developer Tools console?

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: data explorer Issues related to Data Explorer category. enhancement New feature or request usability
Projects
None yet
Development

No branches or pull requests

2 participants