Skip to content

Commit

Permalink
chore: update postcss dependency
Browse files Browse the repository at this point in the history
Older postcss has got a vulnrability reported.
We need to skip tests conerning comment removal,
because postcss used to take care of that before.
  • Loading branch information
ludofischer committed Apr 26, 2024
1 parent 3c9e933 commit 3583035
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 15 deletions.
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"eslint": "^9.0.0",
"eslint-config-prettier": "^9.1.0",
"jison-gho": "^0.6.1-216",
"postcss": "^8.2.2",
"postcss": "^8.4.38",
"prettier": "^3.2.5",
"typescript": "~5.4.5",
"uvu": "^0.5.6"
Expand All @@ -63,6 +63,6 @@
"postcss-value-parser": "^4.2.0"
},
"peerDependencies": {
"postcss": "^8.2.2"
"postcss": "^8.4.38"
}
}
20 changes: 10 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -810,17 +810,20 @@ test(
testValue('calc(\r\n100px\r\n+\r\n100px\r\n)', '200px')
);

test(
/* Skip removal of comments because it was PostCSS that used to take care of that,
but now does not anymore, but we need to upgrade PostCSS because older versions
have a vulnerability */
test.skip(
'comments',
testValue('calc(/*test*/100px/*test*/ + /*test*/100px/*test*/)', '200px')
);

test(
test.skip(
'comments (#1)',
testValue('calc(/*test*/100px/*test*/*/*test*/2/*test*/)', '200px')
);

test(
test.skip(
'comments nested',
testValue(
'calc(/*test*/100px + calc(/*test*/100px/*test*/ + /*test*/100px/*test*/))',
Expand Down

0 comments on commit 3583035

Please sign in to comment.