Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After editing fields and getting an error, the load operation no longer works #12

Open
potaotototo opened this issue Nov 15, 2024 · 1 comment

Comments

@potaotototo
Copy link
Owner

potaotototo commented Nov 15, 2024

Problem

As title.

Steps to reproduce

Edit the json file to corrupt the data first.
Edit the json file again to correct the data back to how it was.
Try to load the same json file.

Expected

Should be able to load or show error.

Actual

Loading file from ...

Screenshot

Screenshot 2024-11-15 at 5.32.51 PM.png

Explanation: the top i first corrupted the data (edited grades in json to become -50)
then i saw error and edited it back to -1, and tried to load the file

Screenshot 2024-11-15 at 5.33.42 PM.png

Potential improvement

Add error detection / handling

@nus-se-script
Copy link

nus-se-script commented Nov 18, 2024

Team's Response


video:https://raw.githubusercontent.com/nus-cs2103-AY2425S1/pe/master/files/91bdfd43-6b31-412e-810e-f7b8032e7062.mp4

The team is unable to reproduce the stated error.

Items for the Tester to Verify

❓ Issue response

Team chose [response.CannotReproduce]

  • I disagree

Reason for disagreement: [replace this with your explanation]


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants