Triggering events on all parent attributes #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Thanks for the plugin! Great work! I was missing a way of triggering events on parent attributes. This is not exactly the same as wildcards because wildcards can be triggered more then once during one call to .set(). Imagine this example:
model.on('change:box.*', transform);
model.set({ 'box.x': 20, 'box.y': 50 });
In this example,
transform()
is called twice which is not desirable. I added a facility so that events are triggered an all the parent attributes as well but only once:model.on('change:box', transform);
model.set({ 'box.x': 20, 'box.y': 50 });
transform()
is now called only once.Hope this might be of use for others as well. Please let me know if I forgot anything or if you feel there is something that should be done differently. Thanks!