Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering events on all parent attributes #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DavidDurman
Copy link

Hi, Thanks for the plugin! Great work! I was missing a way of triggering events on parent attributes. This is not exactly the same as wildcards because wildcards can be triggered more then once during one call to .set(). Imagine this example:

model.on('change:box.*', transform);
model.set({ 'box.x': 20, 'box.y': 50 });

In this example, transform() is called twice which is not desirable. I added a facility so that events are triggered an all the parent attributes as well but only once:

model.on('change:box', transform);
model.set({ 'box.x': 20, 'box.y': 50 });

transform() is now called only once.

Hope this might be of use for others as well. Please let me know if I forgot anything or if you feel there is something that should be done differently. Thanks!

@TheRaven
Copy link

This would be useful for me as well

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants