Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various user- and beatmapset-related sanity checks to submission operations #4

Merged
merged 12 commits into from
Nov 28, 2024

Conversation

bdach
Copy link
Contributor

@bdach bdach commented Nov 22, 2024

Not everything is covered yet, just splitting this off as it has grown large enough to PR before continuing further.

What is covered

  • user status checks (silences / restrictions)
  • required minimum playcount to create a beatmapset
  • user upload quota
  • online status-related checks (no updating of anything ranked/loved/etc., no updating of anything graved if no quota left to revive)
  • beatmap difficulty count limits

What is left to implement (and is coming next / later)

  • skipping upload if nothing actually changed
  • checking that all online IDs in the .osus are valid
  • checking that all the .osus that should be in the package are in it, and that there are no more
  • prevent uploading files with potentially harmful extensions
  • implementation of beatmap revival start-to-end

Size is not great, but most of it is tests, so I hope I can be forgiven.

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks pretty good? Really hard to say what's missing or wrong until we have everything in, so let's keep this moving forward 😄

@peppy peppy merged commit 7cefcac into ppy:master Nov 28, 2024
4 checks passed
@bdach bdach deleted the sanity-checks branch November 28, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants