Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osu!mania legacy skins don't place elements in their correct (mode) default position #22362

Open
MechaFinch opened this issue Jan 22, 2023 · 4 comments · May be fixed by #30867
Open

osu!mania legacy skins don't place elements in their correct (mode) default position #22362

MechaFinch opened this issue Jan 22, 2023 · 4 comments · May be fixed by #30867
Assignees
Labels
area:skinning priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!mania

Comments

@MechaFinch
Copy link

MechaFinch commented Jan 22, 2023

Type

Game behaviour

Bug description

Mania skins imported from stable have a few glaring issues and a slew of much less noticable but still present issues. This report does not include the 'hacky LN' issue, as those are not present in my skin.

From my own skin, there are three major issues when imported:

  1. The HP bar. The HP bar, instead of being placed vertically to the right of the playfield as it would be in stable, is placed horizontally in the top left as if the element is for the new HP bar.
  2. Combo placement. Rather than being in the center of the playfield and placed vertically according to the skin.ini file as in stable, the combo is placed in the bottom left of the screen.
  3. score-percent.png renders differently. A common method (there're even helper programs written for it) for centering the accuracy counter is to make the score-percent.png element a specific width according to screen resolution and the width of accuracy digits. In the case of my skin this a 1076 pixel white bar. For whatever reason it does not render the bar in stable, but does in lazer. If I had to guess it's the lack of any colors other than 0xFFFFFF white. Making the image actually transparent would most likely work as intended in both versions, but this likely has implications for other skins/files.

Aside from these major issues, there are a host of minor but meaningful differences to placement and scaling, and other properties of some elements. The perfectly centered accuracy counter, for example, is no longer centered, but offset by a full character; the score and accuracy counters are both placed down and to the left from their intended positions. The playfield is noticably darker than in stable. That same element is also 2 pixels left of its position on stable (although for once this is more correct than the original). Additionally, the key counter overlay is placed without regard for its absence from stable.

Screenshots or videos

Stable
screenshot036
screenshot037

Lazer
osu_2023-01-22_18-53-32
osu_2023-01-22_18-53-36

Version

2023.123.0-lazer

Logs

input.log
network.log
performance.log
runtime.log
updater.log
database.log

@MechaFinch
Copy link
Author

can't forget the actual skin
mania.zip

@peppy
Copy link
Member

peppy commented Jan 23, 2023

We've made similar fixes for other rulesets, so I think we should support these default locations correctly. Thanks for the skin attachment.

@peppy peppy added ruleset/osu!mania area:skinning priority:1 Very important. Feels bad without fix. Affects the majority of users. labels Jan 23, 2023
@peppy peppy changed the title Mania skins are not imported correctly osu!mania legacy skins don't place elements in their correct default position Jan 23, 2023
@peppy peppy changed the title osu!mania legacy skins don't place elements in their correct default position osu!mania legacy skins don't place elements in their correct (mode) ;default position Jan 23, 2023
@peppy peppy changed the title osu!mania legacy skins don't place elements in their correct (mode) ;default position osu!mania legacy skins don't place elements in their correct (mode) default position Jan 23, 2023
@MechaFinch
Copy link
Author

With lazer making it to the point where pp is possible, I thought I'd revisit.

Mania skin imports remain incorrect for the same reasons as before, but there is something I discovered as a result of now playing with a lane cover.

In skin.ini, ColumnLineWidth is set to all zeroes for all keymodes. On stable this behaves as expected; there is no gap between key sprites, but on lazer there is a 2 pixel (at 1440p) gap between them. I recommend opening the lazer screenshot in a new tab for clarity.

(score-percent appears correct in these screenshots as I changed the file. I do not know if that behaves differently now)

Stable
screenshot198

Lazer
osu_2024-01-31_18-38-15

Skin
- mania lane cover.zip

@salami0133
Copy link

salami0133 commented Nov 15, 2024

you can rotate the hp bar in the skin layout editor
edit: nvm it's a pain having to manually adjust the health bar with the mouse...
image
it's still not quite right and I think the hp bar is rendered in front of the lighting and stuff
image
yea it's a bit hard to make out but I can't unsee it now

@frenzibyte frenzibyte self-assigned this Nov 25, 2024
@frenzibyte frenzibyte linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:skinning priority:1 Very important. Feels bad without fix. Affects the majority of users. ruleset/osu!mania
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants