-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osu!mania legacy skins don't place elements in their correct (mode) default position #22362
Comments
can't forget the actual skin |
We've made similar fixes for other rulesets, so I think we should support these default locations correctly. Thanks for the skin attachment. |
With lazer making it to the point where pp is possible, I thought I'd revisit. Mania skin imports remain incorrect for the same reasons as before, but there is something I discovered as a result of now playing with a lane cover. In ( |
Type
Game behaviour
Bug description
Mania skins imported from stable have a few glaring issues and a slew of much less noticable but still present issues. This report does not include the 'hacky LN' issue, as those are not present in my skin.
From my own skin, there are three major issues when imported:
skin.ini
file as in stable, the combo is placed in the bottom left of the screen.score-percent.png
renders differently. A common method (there're even helper programs written for it) for centering the accuracy counter is to make thescore-percent.png
element a specific width according to screen resolution and the width of accuracy digits. In the case of my skin this a 1076 pixel white bar. For whatever reason it does not render the bar in stable, but does in lazer. If I had to guess it's the lack of any colors other than 0xFFFFFF white. Making the image actually transparent would most likely work as intended in both versions, but this likely has implications for other skins/files.Aside from these major issues, there are a host of minor but meaningful differences to placement and scaling, and other properties of some elements. The perfectly centered accuracy counter, for example, is no longer centered, but offset by a full character; the score and accuracy counters are both placed down and to the left from their intended positions. The playfield is noticably darker than in stable. That same element is also 2 pixels left of its position on stable (although for once this is more correct than the original). Additionally, the key counter overlay is placed without regard for its absence from stable.
Screenshots or videos
Stable
Lazer
Version
2023.123.0-lazer
Logs
input.log
network.log
performance.log
runtime.log
updater.log
database.log
The text was updated successfully, but these errors were encountered: