Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ARRAY_ABS_BOUNDS(...) where possible #379

Closed
hanno-becker opened this issue Nov 12, 2024 · 0 comments · Fixed by #381
Closed

Use ARRAY_ABS_BOUNDS(...) where possible #379

hanno-becker opened this issue Nov 12, 2024 · 0 comments · Fixed by #381
Labels
CBMC enhancement New feature or request

Comments

@hanno-becker
Copy link
Contributor

#371 introduces ARRAY_ABS_BOUNDS for absolute array bounds, which should be applicable in most places that currently use ARRAY_IN_BOUNDS. Find and replace those instances.
@hanno-becker hanno-becker added enhancement New feature or request CBMC labels Nov 12, 2024
@hanno-becker hanno-becker mentioned this issue Nov 12, 2024
Merged
mkannwischer added a commit that referenced this issue Nov 12, 2024
@mkannwischer
CBMC: Use ARRAY_ABS_BOUND everywhere
e651344 
#371 introduced a new macro
ARRAY_ABS_BOUND for bounds that are centered around zero.
This commit makes use of that macro everywhere.

Resolves #379

Signed-off-by: Matthias J. Kannwischer <[email protected]>
@mkannwischer mkannwischer mentioned this issue Nov 12, 2024
Merged
mkannwischer added a commit that referenced this issue Nov 12, 2024
@mkannwischer
CBMC: Use ARRAY_ABS_BOUND everywhere
6b0489b 
#371 introduced a new macro
ARRAY_ABS_BOUND for bounds that are centered around zero.
This commit makes use of that macro everywhere.

Resolves #379

Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer added a commit that referenced this issue Nov 12, 2024
@mkannwischer
CBMC: Use ARRAY_ABS_BOUND everywhere
a308c4c 
#371 introduced a new macro
ARRAY_ABS_BOUND for bounds that are centered around zero.
This commit makes use of that macro everywhere.

Resolves #379

Signed-off-by: Matthias J. Kannwischer <[email protected]>
mkannwischer added a commit that referenced this issue Nov 12, 2024
@mkannwischer
CBMC: Use ARRAY_ABS_BOUND everywhere
f739eb9 
#371 introduced a new macro
ARRAY_ABS_BOUND for bounds that are centered around zero.
This commit makes use of that macro everywhere.

Resolves #379

Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker pushed a commit that referenced this issue Nov 12, 2024
@mkannwischer @hanno-becker
CBMC: Use ARRAY_ABS_BOUND everywhere
01e0203 
#371 introduced a new macro
ARRAY_ABS_BOUND for bounds that are centered around zero.
This commit makes use of that macro everywhere.

Resolves #379

Signed-off-by: Matthias J. Kannwischer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CBMC enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CBMC: More minor clean-up pq-code-package/mlkem-native
1 participant
@hanno-becker