Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SLIP encoding (OSC v1.1) #24

Open
Levi-Lesches opened this issue Aug 29, 2024 · 1 comment
Open

Support SLIP encoding (OSC v1.1) #24

Levi-Lesches opened this issue Aug 29, 2024 · 1 comment

Comments

@Levi-Lesches
Copy link

My team uses this package to parse data coming from a device that conforms to OSC v1.1, which means it uses SLIP. This inserts bytes at the end of messages and also escapes certain bytes.

To this library, this means "random bytes" appear in the payload, and the library either fails to parse the data or returns non-sensical data. If the escaped bytes appear in the timetag... the code will work for most of the year, then stop working completely for days or longer.

I fixed this in my own project, and my team continues to rely on this package, so I am more than happy to upstream those changes in a PR. For reference, here is how Rug.OSC (C#) handles this.

If you'd like any other help maintaining this package (as I noticed a few open issues), we can offer some support there as well

@pq
Copy link
Owner

pq commented Sep 5, 2024

So cool! If you'd like to upstream that support, that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants