Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check v6 direct-key self signature #3

Open
TJ-91 opened this issue Jan 16, 2023 · 2 comments
Open

Check v6 direct-key self signature #3

TJ-91 opened this issue Jan 16, 2023 · 2 comments
Labels
v6 req. deferred to upstream A requirement for v6 which we don't implement and which we need to inform the upstream project about

Comments

@TJ-91
Copy link
Collaborator

TJ-91 commented Jan 16, 2023

Check to implement:

An implementation MUST ensure that a valid direct-key signature is present before using a v6 key. This prevents certain attacks where an adversary strips a self-signature specifying a key expiration time or certain preferences.

Is my understanding correct that self signatures are always done by the primary key, i.e., an encryption subkey directkey self-signature is issued by the primary key?
What about signature subkeys with key usage flag 0x01?

@falko-strenzke
Copy link
Contributor

falko-strenzke commented Jan 17, 2023

Check to implement:

An implementation MUST ensure that a valid direct-key signature is present before using a v6 key. This prevents certain attacks where an adversary strips a self-signature specifying a key expiration time or certain preferences.

Is my understanding correct that self signatures are always done by the primary key, i.e., an encryption subkey directkey self-signature is issued by the primary key? What about signature subkeys with key usage flag 0x01?

From what I read under 5.2.3.7, it seems that direct-key self signatures are only described / considered for the case of a primary key making the signature. The only case of certification signatures made by a subkey I am aware of is the primary key binding signature, which is not in the list of signature types in the beginning of that section, nor is it mentioned anywhere in that section.

I am not sure if signature subkeys with certification capability are meant to exist (though probably not explicitly excluded by the standard). If at all, then probably only to certify other keys, but not the own primary key.

@falko-strenzke falko-strenzke changed the title Check v5 direct-key self signature Check v6 direct-key self signature Feb 5, 2024
@falko-strenzke falko-strenzke added Change for Upstream Integration v6 req. deferred to upstream A requirement for v6 which we don't implement and which we need to inform the upstream project about and removed Change for Upstream Integration labels Feb 5, 2024
@falko-strenzke
Copy link
Contributor

Unclear whether RNP v6 code checks the presence of the direct-key self signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v6 req. deferred to upstream A requirement for v6 which we don't implement and which we need to inform the upstream project about
Projects
None yet
Development

No branches or pull requests

2 participants