Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v6 keyid is calculated incorrectly. #41

Closed
ni4 opened this issue Jul 25, 2023 · 6 comments
Closed

v6 keyid is calculated incorrectly. #41

ni4 opened this issue Jul 25, 2023 · 6 comments

Comments

@ni4
Copy link
Collaborator

ni4 commented Jul 25, 2023

Description

As of section 5.5.4.3 from crypto-refresh draft, "The Key ID is the high-order 64 bits of the fingerprint.", while code in tb-pqc uses v4 approach (low-order bits).
@ni4
Copy link
Collaborator Author

ni4 commented Jul 25, 2023 •
edited
Loading

...this is also apply to the method pgp_signature_t::keyid()

@TJ-91
Copy link
Collaborator

TJ-91 commented Jul 25, 2023

That's correct, we missed that. pgp_keyid() in fingerprint.cpp seems to do the same calculation. Changing those two places should be enough, right?

@ni4
Copy link
Collaborator Author

ni4 commented Jul 25, 2023

@TJ-91 Yeah, I think so. I already implemented this in v5 draft PR here: rnpgp/rnp#2111 , so you may take a look there.

TJ-91 added a commit that referenced this issue Jul 26, 2023
@TJ-91
fix v6 key id calculation, issue #41 [rebase into ce9c49f]
31c5b0c
falko-strenzke pushed a commit that referenced this issue Jul 26, 2023
@TJ-91 @falko-strenzke
fix v6 key id calculation, issue #41 [rebase into v6 key & sig]
8411645
falko-strenzke pushed a commit that referenced this issue Jul 26, 2023
@TJ-91 @falko-strenzke
fix v6 key id calculation, issue #41 [rebase into v6 key & sig]
dcb7636
@TJ-91
Copy link
Collaborator

TJ-91 commented Aug 1, 2023

This should be correctly implemented now. I aligned this to your code and should be easy to merge

falko-strenzke pushed a commit that referenced this issue Sep 5, 2023
@TJ-91 @falko-strenzke
fix v6 key id calculation, issue #41 [rebase into v6 key & sig]
82a1186
@falko-strenzke
Copy link
Contributor

@TJ-91 Can we close this now?

@TJ-91
Copy link
Collaborator

TJ-91 commented Oct 9, 2023

yes

@TJ-91 TJ-91 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ni4 @TJ-91 @falko-strenzke