Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The install script brutally mangles the plugins part of .zshrc file #2001

Open
Tyrn opened this issue Nov 15, 2024 · 1 comment
Open

The install script brutally mangles the plugins part of .zshrc file #2001

Tyrn opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@Tyrn
Copy link

Tyrn commented Nov 15, 2024

Bug Report

Description

The ~/HyDE/Scripts/install.sh script just replaces the line plugins = ... with

plugins=( git sudo zsh-256color zsh-autosuggestions zsh-syntax-highlighting )

Steps to Reproduce

Just use any existing .zshrc file before installation, already with the plugins clause in place. I got lucky because with my formatting I got parentheses discrepancy right away.

-plugins=( git sudo zsh-256color zsh-autosuggestions zsh-syntax-highlighting )
+plugins=(
+    git python docker systemd sudo vi-mode
+    mise
+    zsh-256color zsh-autosuggestions zsh-syntax-highlighting
+)

My first line plugins=( just got nuked and replaced with the whole

plugins=( git sudo zsh-256color zsh-autosuggestions zsh-syntax-highlighting )

Syntax error, thankfully. In case of a one line plugins declaration it gets replaced silently.

@Tyrn Tyrn added the bug Something isn't working label Nov 15, 2024
@kRHYME7 kRHYME7 self-assigned this Nov 15, 2024
@kRHYME7
Copy link
Collaborator

kRHYME7 commented Nov 15, 2024

check

https://github.com/prasanthrangan/hyprdots/blob/main/Scripts%2Frestore_zsh.lst#L1-L8

https://github.com/prasanthrangan/hyprdots/blob/main/Scripts%2Frestore_shl.sh#L22-L46

The script only supports 1 liner for the plugin array.
It's easier to parse. I will try to see what I can do about this one.

also this repo is meant to be forked and the *.lst files should be edited manually. That's what I understand as he usually won't accept PRs with sophisticated/interactive install.sh.

So to skip zshrc, use N|Y flag in the restore_cfg.lst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants