Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raising exceptions instead of prints/returns #3

Open
prashantsengar opened this issue Dec 16, 2020 · 0 comments
Open

Raising exceptions instead of prints/returns #3

prashantsengar opened this issue Dec 16, 2020 · 0 comments
Labels
Easy enhancement New feature or request

Comments

@prashantsengar
Copy link
Owner

In the code, we are handling the exceptions on our own in most of the cases. Example, in makeFolders we return True/False and do not raise Exceptions. This leads to the user not being able to find out the exact reason the code is not working.

We should rather raise exceptions in such cases.

But in cases like where we are downloading the files, it is better to print or add logging statements.

@prashantsengar prashantsengar added Easy enhancement New feature or request labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant