Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update driver-pravega after 0.8.0 Pravega release #36

Closed
jingerbread opened this issue Jul 16, 2020 · 1 comment · Fixed by #51
Closed

Update driver-pravega after 0.8.0 Pravega release #36

jingerbread opened this issue Jul 16, 2020 · 1 comment · Fixed by #51

Comments

@jingerbread
Copy link
Contributor

jingerbread commented Jul 16, 2020

Update omb driver-pravega after 0.8.0 Pravega release

  1. Change controller.zk.url to controller.zk.connect.uri in templates/controller.config.properties
[root@W10J6T4733 deploy]# grep -r "controller.zk.url" *
templates/controller.config.properties:controller.zk.url={{ zookeeperServers }}
  1. Change io.pravega:pravega-client version from 0.7.1 to 0.8.0 in driver-pravega/pom.xml
<!-- https://mvnrepository.com/artifact/io.pravega/pravega-client -->
 <dependency>
    <groupId>io.pravega</groupId>
    <artifactId>pravega-client</artifactId>
    <version>0.8.0</version>
  </dependency>
  1. Change pravegaVersion and update zookeeper(optional), bookkeeper and prometheus(optional) versions in driver-pravega/deploy/vars.yaml
---
pravegaVersion: "0.8.0"
zookeeperVersion: "3.6.1"
bookkeeperVersion: "4.9.2"
prometheusVersion: "2.18.1"
pravegaContainersPerSegmentStore: 8
  1. Use official Pravega tester image in driver-pravega/deploy/deploy.yaml Run Pravega Tester task Use official Pravega tester image #35

  2. Use Pravega official graphana image with Pravega dashboards instead of currently grafana/grafana:latest

  • Add automatic InfluxDB datasource adding to grafana.
  1. Update properties in driver-pravega/deploy/templates directory
    However, seems after Issue 4712 breaking properties changes, we need to update all affected properties in driver-pravega
    Otherwise, we can have problems with deployment or f.e metrics collecting

Issue 4712: Inconsistently and confusingly named configuration keys #4712
pravega/pravega#4712
Issue 4900: Fix configuration related issues in templates and docs #4905
pravega/pravega#4905

Refer to Configuration Naming Guidelines
https://github.com/pravega/pravega/wiki/Configuration-Naming-Guidelines

@jingerbread
Copy link
Contributor Author

May be we can fix license check warnings by adding license headers?

[WARNING] Missing header in: C:/DELL_EMC/Development/OMB/pravega-omb/driver-pulsar/deploy/templates/chrony.conf
[WARNING] Missing header in: C:/DELL_EMC/Development/OMB/pravega-omb/driver-kafka/deploy/templates/chrony.conf
[WARNING] Missing header in: C:/DELL_EMC/Development/OMB/pravega-omb/driver-pravega/deploy/templates/bkenv.sh
...

-Dlicense.skip=true is the com.mycila plugin flag to skip checks, see "Request for a skip check goal. #28" mathieucarbou/license-maven-plugin#28 closed in 2013, so think it will work.
In omb com.mycila.license-maven-plugin:3.0 is used for checking license headers:

<plugin>
	<groupId>com.mycila</groupId>
	<artifactId>license-maven-plugin</artifactId>
	<version>3.0</version>
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant