Issue 10: Extend schema registry integration #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
…che for test. Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
Signed-off-by: Andrew Robertson <[email protected]>
karansinghneu
approved these changes
Mar 30, 2021
fpj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
Please refer to the wiki for a full description of how we list schemas, tables, interact with schema regsitry
https://github.com/adrdc/presto-connector/wiki/Schema-Registry
This PR abstracts out listing of scheams, tables, and interacting with a schema registry.
Any schema registry could be implemented. Confluent schema registry is added as an example (in addition to local file and pravega schema registry which previously existed).
PravegaTableDescriptionSupplier
Results in a lot of refactoring here. Most things moved to LocalSchemaRegistry + PravegaSchemaRegistry.
As a result this is much simpler+cleaner.
Integration tests
Integration tests now use the LocalSchemaRegistry component (vs. seeding the cache). So this results in a lot more code coverage during test.