Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Button /> should support <a /> and <Link /> functionality #147

Open
Tracked by #81
jessepinho opened this issue Aug 8, 2024 · 0 comments
Open
Tracked by #81

<Button /> should support <a /> and <Link /> functionality #147

jessepinho opened this issue Aug 8, 2024 · 0 comments

Comments

@jessepinho
Copy link
Contributor

jessepinho commented Aug 8, 2024

Currently, the docs I wrote for <Button /> incorrectly state that, to use it as a link, you can simply wrap it inside an <a /> or <Link /> tag/component. However, this is invalid HTML, and results in an issue @VanishMax discovered where users must hit Tab twice for each button wrapped in a link.

To fix this, the <Button /> component should be rewritten to be able to take the form of a link. We'll have to be thoughtful about this, since we don't only want to support <a />, but also any type of other link component that libraries like React Router use for links (in React Router's case, the <Link /> component).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🗄️ Backlog
Development

No branches or pull requests

1 participant