Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make PraxRevoke an InternalMessage and possibly collect with ServicesMessage #184

Open
turbocrime opened this issue Aug 27, 2024 · 0 comments
Open

make PraxRevoke an InternalMessage and possibly collect with ServicesMessage #184

turbocrime opened this issue Aug 27, 2024 · 0 comments

Comments

@turbocrime
Copy link
Contributor

https://github.com/prax-wallet/web/blob/bc5d8af6557e521574fe667b63bc7f0a4ffcddb5/apps/extension/src/message/revoke.ts#L1-L3

https://github.com/prax-wallet/web/blob/bc5d8af6557e521574fe667b63bc7f0a4ffcddb5/apps/extension/src/message/services.ts#L1-L4

if combined, would require a change in the location of the ServicesMessage handler. ServicesMessage members that are string-only would change type.
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Labs web Aug 27, 2024
grod220 added a commit that referenced this issue Dec 3, 2024
@grod220
Update all deps to latest (#184)
7a8ad0c 
* update deps

* updating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Labs web
Status: 🗄️ Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turbocrime