Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update identify on the runner image #257

Closed
burgholzer opened this issue Apr 22, 2024 · 4 comments · Fixed by #258
Closed

Update identify on the runner image #257

burgholzer opened this issue Apr 22, 2024 · 4 comments · Fixed by #258

Comments

@burgholzer
Copy link
Contributor

Hey 👋🏼

I really hope that this is the right place to ask for this.

pre-commit/mirrors-clang-format#32 just got merged two weeks ago and includes a type that was introduced to the identify library in pre-commit/identify#441, which is part of the v2.5.35 release.
As far as I understood, the runner image is currently using 2.5.27 (

identify==2.5.27
).
Because of that, every auto-update PR generated by pre-commit.ci that updates

will currently fail with an error message that contains

=====> Type tag 'metal' is not recognized.  Try upgrading identify and pre-commit?

And while I know how to fix this locally (following the error message), if have no control over the pre-commit.ci system running these checks.

Based on previous commits in this repository (like 5623f48) I wasn't sure how to best update all the versions myself to submit a PR.
Hence this issue. Thanks for your time.

@asottile
Copy link
Member

the version of identify comes from here:

identify==2.5.27

@burgholzer
Copy link
Contributor Author

the version of identify comes from here:

identify==2.5.27

Which is what I tagged above 👆🏻
Guess my question is if it enough to just upgrade that (happy to submit a PR in that case) or if anything else needs to be considered.

@louwers
Copy link

louwers commented Apr 23, 2024

Thanks for the fix. I'm guessing this will be rolled out soon?

@asottile
Copy link
Member

this should be live now -- also batched some other updates into this so it took a little bit longer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants