Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compare and document accuracy of results in partitioned heat conduction (OpenFOAM vs FEniCS) #445

Open
MakisH opened this issue Jan 19, 2024 · 2 comments
Assignees

Comments

@MakisH
Copy link
Member

MakisH commented Jan 19, 2024

Originally posted by @BenjaminRodenberg in #406 (review)

I guess there was already an error/inaccuracy (compared to the FEniCS case) in how you are treating the boundary conditions before. I would suggest to open an issue and try to fix this to reach the same accuracy as for the FEniCS case without subcycling in a separate PR. Not sure whether this is actually possible with OpenFOAM: In FEniCS, I needed 2nd order FEM to do the trick with the flux. I have no idea about the capabilities of OpenFOAM and FV here.

@MakisH
Copy link
Member Author

MakisH commented Mar 28, 2024

@BenjaminRodenberg any clarifications / updates on this? Otherwise, I would just close it as not planned, as it is currently unclear.

Note that, in the meantime, we changed the technical implementation of the boundary condition in this OpenFOAM case: #428 #501.

@MakisH MakisH removed this from the v202403.0 milestone Jul 2, 2024
@BenjaminRodenberg
Copy link
Member

Let's not close this issue. The value of the case lies in the fact that you can compute the result at very high accuracy and spot errors in the adapter (or elsewhere) quickly by comparing to the analytical solution. Locating the source of the error is then a different story, but this case really helps to unit test the features of an adapter quite well if you pick the right settings.

I think this is something where we should sit down together since I'm lacking the OpenFOAM knowledge and I guess I could help you here with my knowledge about the numerics of the case. Let's see, if we find time for this during the next coding days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants