Refactor existing & add new details in Iceberg document #20552

agrawalreetika · 2023-08-11T08:13:23Z

Description

Refactor existing & add new details in the Iceberg document.

Motivation and Context

Refactor existing Iceberg document & also add new details to it
Resolves #20543

Impact

Provide more concrete details to users about available features in the Iceberg connector.

Existing Document -

After PR changes -

Test Plan

Contributor checklist

Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
Documented new properties (with its default value), SQL syntax, functions, or other functionality.
If release notes are required, they follow the release notes guidelines.
Adequate tests were added if applicable.
CI passed.

Release Notes

== NO RELEASE NOTE ==

github-actions · 2023-08-11T08:14:33Z

Codenotify: Notifying subscribers in CODENOTIFY files for diff 815bf40...d9015e6.

Notify	File(s)
@steveburnett	presto-docs/src/main/sphinx/connector/iceberg.rst

tdcmeehan · 2023-08-11T13:54:50Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+Metastores
+-----------
+Iceberg tables stores most of the metadata in the metadata files along with the data on the filesystem.
+But to store small amount of metadata it still requires Metastore to find the current location of the current


Suggested change

But to store small amount of metadata it still requires Metastore to find the current location of the current

But to store small amount of metadata it still requires a central place to find the current location of the current

tdcmeehan · 2023-08-11T13:55:21Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+-----------
+Iceberg tables stores most of the metadata in the metadata files along with the data on the filesystem.
+But to store small amount of metadata it still requires Metastore to find the current location of the current
+metadata pointer for a table. This central place is called ``Iceberg Catalog``.


Suggested change

metadata pointer for a table. This central place is called ``Iceberg Catalog``.

metadata pointer for a table. This central place is called the ``Iceberg Catalog``.

tdcmeehan · 2023-08-11T13:56:52Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+    To use Hadoop as Catalog with Iceberg table, catalog requires ``hive.metastore.uri`` property
+    added even though it doesn't rely on metastore for metadata when using Hadoop Catalog. You
+    can provide a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will not
+    be needed once check for ``hive.metastore.uri`` property is removed in case of Hadoop Catalog.


Suggested change

To use Hadoop as Catalog with Iceberg table, catalog requires ``hive.metastore.uri`` property

added even though it doesn't rely on metastore for metadata when using Hadoop Catalog. You

can provide a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will not

be needed once check for ``hive.metastore.uri`` property is removed in case of Hadoop Catalog.

To use Hadoop as Catalog with Iceberg table, catalog requires the ``hive.metastore.uri`` property

added even though it doesn't rely on metastore for metadata when using Hadoop Catalog. You

can provide a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will be fixed in a future release of Presto.

Is there an open issue for this BTW?

Yes there are 2 issues reporting the same - #17342

yingsu00

@agrawalreetika Thanks for putting this up so quickly! See my comment in line

yingsu00 · 2023-08-12T01:08:05Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+Metastores
+-----------
+Iceberg tables stores most of the metadata in the metadata files along with the data on the filesystem.
+But to store small amount of metadata it still requires Metastore to find the current location of the current


I think we should remove the "to store small amount of metadata".

Iceberg tables stores most of the metadata in the metadata files along with the data on the filesystem, but it still requires ...

yingsu00 · 2023-08-12T01:11:50Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+Iceberg tables stores most of the metadata in the metadata files along with the data on the filesystem.
+But to store small amount of metadata it still requires Metastore to find the current location of the current
+metadata pointer for a table. This central place is called ``Iceberg Catalog``.
+The Iceberg connector supports different types of Iceberg Catalogs : ``Hive Metastore``,


"The Iceberg connector" -> "The Presto Iceberg connector"

yingsu00 · 2023-08-12T01:16:50Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+But to store small amount of metadata it still requires Metastore to find the current location of the current
+metadata pointer for a table. This central place is called ``Iceberg Catalog``.
+The Iceberg connector supports different types of Iceberg Catalogs : ``Hive Metastore``,
+``GLUE``, ``NESSIE``, ``HADOOP``

 To configure the Iceberg connector, create a catalog properties file


I think it is better to highlight the iceberg.catalog.type property here. Would you please add a sentence for it?

yingsu00 · 2023-08-12T01:26:34Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -346,6 +232,8 @@ Extra Hidden Metadata Tables
 The Iceberg connector exposes extra hidden metadata tables. You can query these
 as a part of SQL query by appending name with the table.

+``$properties`` Table


This comment is for Line 196. Will you be able to add some explanation there to say those properties are available for all Presto tables, not just Iceberg tables?

@yingsu00 Under Table Properties in the Iceberg document some properties that are mentioned are I think specific to the Iceberg table like partitioning, location & format_version.
For hive connector, these are partitioned_by , external_location respectively & format_version is not there for Hive.
Please correct me if you were talking about something else here.

@agrawalreetika yes I mean it would help the users to mention if they are Iceberg specific, or the same with Hive, just as you explained above.

yingsu00 · 2023-08-12T01:30:28Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -415,7 +311,7 @@ as a part of SQL query by appending name with the table.
       0     | s3://my-bucket/ctas_nation/data/9f889274-6f74-4d28-8164-275eef99f660.parquet | PARQUET     |           25 |               1648 | {1=52, 2=222, 3=105, 4=757} | {1=25, 2=25, 3=25, 4=25} | {1=0, 2=0, 3=0, 4=0} |  NULL            | {1=0, 2=ALGERIA, 3=0, 4= haggle. careful} | {1=24, 2=VIETNAM, 3=4, 4=y final packaget} | NULL         | NULL          | NULL

 Time Travel
------------------------
+-----------


This comment is for ln 323
At this moment, the Schema Evolution has not been talked about.

And for line 355, you mentioned we just created the ctas table, but this was not mentioned anywhere above. It might be good to have basic DDL and DML sections before the SELECT queries.

This comment is for ln 323 At this moment, the Schema Evolution has not been talked about.

Ok, I will shift Schema Evolution before Time Travel Section in the document

And for line 355, you mentioned we just created the ctas table, but this was not mentioned anywhere above. It might be good to have basic DDL and DML sections before the SELECT queries.

@yingsu00 In the Example Queries section of the same there first query is CTAS, and all the further queries are done on the same table. Please let me know if anything is missing here.

yingsu00 · 2023-08-12T01:42:09Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+The Iceberg connector supports querying and manipulating Iceberg tables and schemas
+(databases). Here are the examples of SQL Operations supported from Presto :
+
+Create a schema


CREATE SCHEMA

yingsu00 · 2023-08-12T01:42:29Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+    CREATE SCHEMA iceberg.web
+    WITH (location = 's3://my-bucket/')
+
+Create table


Upper case, ditto

yingsu00 · 2023-08-12T01:47:09Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+     comment   | varchar |       |
+    (4 rows)
+
+Examples


This title is not appropriate. Other top level titles were all Iceberg operations or properties, and they all contain examples. I think we can rename it to SQL Support.

Also these DDL and DML better to be moved before Time Travel.

yingsu00 · 2023-08-12T01:50:02Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+Drop a schema::
+
+    DROP SCHEMA iceberg.web
+


I don't see the section for INSERT, DELETE, Merge or upsert? Let's have a section for it and state clearly what is supported and what is not.

I missed the INSERT example, will add that

For DELETE I have mentioned in Iceberg Connector Limitations section that it's only supported if the WHERE clause matches entire partitions. Do we need section for DELETE as well?

MERGE & UPDATE sql syntax is not yet supported in Presto. I will open an issue for the same

yingsu00 · 2023-08-12T01:55:20Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -415,7 +311,7 @@ as a part of SQL query by appending name with the table.
       0     | s3://my-bucket/ctas_nation/data/9f889274-6f74-4d28-8164-275eef99f660.parquet | PARQUET     |           25 |               1648 | {1=52, 2=222, 3=105, 4=757} | {1=25, 2=25, 3=25, 4=25} | {1=0, 2=0, 3=0, 4=0} |  NULL            | {1=0, 2=ALGERIA, 3=0, 4= haggle. careful} | {1=24, 2=VIETNAM, 3=4, 4=y final packaget} | NULL         | NULL          | NULL

 Time Travel
------------------------
+-----------


Shall we add a section for SELECT support before Time travel? We can explain what type of Iceberg queries are supported by Presto there, e.g. read optimized, delta, real-time. We can also explain the support of COW and MOR tables there, or before talking about table properties

@yingsu00 I have added the SELECT section in the SQL Support section. Since currently Iceberg format version 1 & version 2 both read support is there but with limitations on version 2 tables where Delete files are present. I have mentioned that limitation as well. Please let me know if we should add any further details there.

agrawalreetika · 2023-08-12T10:11:44Z

Thanks, @tdcmeehan & @yingsu00 for your review. I have amended the changes as mentioned & replied to few. Please take a pass on the changes.

steveburnett

Looks great! I found a couple of small suggestions that I made comments for.

presto-docs/src/main/sphinx/connector/iceberg.rst

yingsu00

Mostly look good. But will you be able to check if double back quotation marks should be used for many places, e.g. rollback_to_snapshot was only singly quoted, and its not highlighted on my browser.

yingsu00 · 2023-08-15T00:45:56Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -11,12 +11,17 @@ The Iceberg connector allows querying data stored in Iceberg tables.

    It is recommended to use Iceberg 0.9.0 or later.


I'm not sure how user can choose the Iceberg version with Presto?

Yes, that's right. Users will not have any control over this from the Presto engine side. And current Iceberg version in Presto is 1.3.1. As I checked Presto iceberg connector started from 0.9.0 this might have been highlighted from there for other engines.

0.9.0 was the version we tested when we developed the connector. During that time, we ran some tests, such as using Presto to query iceberg tables (0.9.0) written by Spark. The version information is a bit outdated now. We probably could safely remove this note.

yingsu00 · 2023-08-15T00:47:10Z

presto-docs/src/main/sphinx/connector/iceberg.rst

-``etc/catalog/iceberg.properties`` with the following contents,
-replacing the properties as appropriate:
+``etc/catalog/iceberg.properties``. To define catalog type ``iceberg.catalog.type`` property is
+required along with the following contents, replacing the properties as appropriate:


To define the catalog type, iceberg.catalog.type property is ...

, replacing the properties as appropriate:
->
, with the properties' values properly replaced:

@tdcmeehan do you have better recommendations?

with the properties' values replaced as follows:

yingsu00 · 2023-08-15T00:51:18Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+.. note::
+
+    To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property, even


hive.metastore.uri was not quoted

yingsu00 · 2023-08-15T00:53:25Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+.. note::
+
+    To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property, even


To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property,
-->
To use Hadoop catalog with Iceberg table, it requires the hive.metastore.uri property,

yingsu00 · 2023-08-15T00:55:36Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+    To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property, even
+    though it doesn't rely on metastore for metadata when using Hadoop Catalog. You can provide
+    a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will be fixed in a


I don't quite understand "You can provide a placeholder with hive.metastore.uri=thrift://localhost:9083". What is the placeholder? Does thrift://localhost:9083 have to be exactly the same? And how will it be fixed? It'll be nice if you can explain it better.

I have put up details about the issue in here #19920
Currently since hive.metastore.uri property can not be null when using Hadoop as a catalog in Iceberg connector, we have to specify some placeholder for hive.metastore.uri property (doesn't necessarily have to be thrift://localhost:9083) which has to be fixed in this case since Hadoop catalog doesn't require any HMS for metadata.

Open for suggestions on how we want to add a note here about this, we can also add this issue link in the document until this is fixed?

The Presto metadata store and Iceberg metadata store are two independent designs but they are coupled in the Presto-Iceberg connector, which, as a consequence, causes the dependency on the Hive metastore although the Iceberg Hadoop catalog doesn't use that.
Adding an issue link here looks good to me. Or add it to the Section Iceberg Connector Limitations. Your call.

yingsu00 · 2023-08-15T01:01:07Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+    )
+    WITH (
+      format = 'ORC',
+      partitioning = ARRAY['ds', 'country']


Do we support partition column transformations? If yes, let's add a sub section here. If not, then add a line saying these are not supported yet.

Yes, we do. I will add the section for it.

Presto Iceberg Connector currently already supports Bucket & Truncate transform with partition column in Iceberg Table. For Day, Month, Year, Hour Created Issue - #20570

yingsu00 · 2023-08-15T01:05:35Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+.. note::
+
+    Iceberg Tables with format version 2 where delete files are present are not filtered in ``SELECT``


Does it mean it gives wrong results? "are not filtered in" is kind of vague here. Can you use more precise words?

Iceberg Tables with format version 2 where delete files are present are not filtered in SELECT operations in Presto, and which will produce wrong results without filtering.
-->
The SELECT operations on Iceberg Tables with format version 2 do not read the delete files and remove the deleted rows as of now.

Please update the last section too.

yingsu00 · 2023-08-15T01:08:36Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+     zipcode   | varchar |       |
+    (5 rows)
+
+We can also rename the new column to `location`:


to location. -> to another name, e.g. location

I feel just "location" would likely to be confused with the table property "location"

yingsu00 · 2023-08-15T01:09:30Z

presto-docs/src/main/sphinx/connector/iceberg.rst

 Time Travel
------------------------
+-----------

 Iceberg and Presto Iceberg connector supports time travel via table snapshots
 identified by unique snapshot IDs. The snapshot IDs are stored in the `$snapshots`


$snapshots was not highlighted. Should it be double quoted?

yingsu00 · 2023-08-15T01:12:26Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+-----------------------------
+
+* :doc:`/sql/delete` is only supported if the ``WHERE`` clause matches entire partitions.
+* Iceberg Tables using v2 of the Iceberg specification where delete files are present are


Explain better here too

agrawalreetika · 2023-08-15T07:44:14Z

Mostly look good. But will you be able to check if double back quotation marks should be used for many places, e.g. rollback_to_snapshot was only singly quoted, and its not highlighted on my browser.

Sure. As I checked All the metadata table access requires double quotes but in procedure calls for ex - rollback_to_snapshot database & table names require single quotes.

ChunxuTang

@agrawalreetika Thanks for your nice work!
I just left some minor comments/explanations. Hope these could be helpful for your work.

ChunxuTang · 2023-08-15T15:58:57Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -11,12 +11,17 @@ The Iceberg connector allows querying data stored in Iceberg tables.

    It is recommended to use Iceberg 0.9.0 or later.


0.9.0 was the version we tested when we developed the connector. During that time, we ran some tests, such as using Presto to query iceberg tables (0.9.0) written by Spark. The version information is a bit outdated now. We probably could safely remove this note.

ChunxuTang · 2023-08-15T16:03:37Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+    To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property, even
+    though it doesn't rely on metastore for metadata when using Hadoop Catalog. You can provide
+    a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will be fixed in a


The Presto metadata store and Iceberg metadata store are two independent designs but they are coupled in the Presto-Iceberg connector, which, as a consequence, causes the dependency on the Hive metastore although the Iceberg Hadoop catalog doesn't use that.
Adding an issue link here looks good to me. Or add it to the Section Iceberg Connector Limitations. Your call.

ChunxuTang · 2023-08-15T16:16:42Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+                                                   ``LZ4``, and ``ZSTD``.
+
+``iceberg.catalog.type``                           The catalog type for Iceberg tables. The available values     ``hive``
+                                                   are ``hive``, ``hadoop``, and ``nessie`` corresponding to


And glue?

For glue, we need to set iceberg.catalog.type=hive. Details of each catalog property are also mentioned in the respective catalog section.

thanks for the clarification.

agrawalreetika · 2023-08-15T20:27:22Z

Thank you @yingsu00 @tdcmeehan @ChunxuTang & @steveburnett for your review. I have made changes as per the comments. Please take a pass if the details look good.

steveburnett · 2023-08-15T21:00:12Z

presto-docs/src/main/sphinx/connector/iceberg.rst

@@ -48,8 +49,16 @@ Nessie catalog
 ^^^^^^^^^^^^^^

 In order to use a Nessie catalog, ensure to configure the catalog type with


Maybe this line could be rephrased as shorter without changing the meaning? Consider if "To use a Nessie catalog, configure the catalog type as" still means what you want it to mean here.

yingsu00

@agrawalreetika Some minor modifications in line...

yingsu00 · 2023-08-17T00:48:13Z

presto-docs/src/main/sphinx/connector/iceberg.rst


 To configure the Iceberg connector, create a catalog properties file
-``etc/catalog/iceberg.properties`` with the following contents,
-replacing the properties as appropriate:
+``etc/catalog/iceberg.properties``. To define catalog type ``iceberg.catalog.type`` property is


To define catalog type ...
->
To define the catalog type, ...

Note the comma needs to be there

yingsu00 · 2023-08-17T00:49:12Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+filesystem, but it still requires a central place to find the current location of the
+current metadata pointer for a table. This central place is called the ``Iceberg Catalog``.
+The Presto Iceberg connector supports different types of Iceberg Catalogs : ``Hive Metastore``,
+``GLUE``, ``NESSIE``, ``HADOOP``


NESSIE, HADOOP
-->
NESSIE, and HADOOP.

yingsu00 · 2023-08-17T00:55:09Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+.. note::
+
+    To use Hadoop catalog with Iceberg table, it requires the ``hive.metastore.uri`` property, even
+    though it doesn't rely on metastore for metadata when using Hadoop Catalog. You can provide


it doesn't rely on metastore for metadata when using Hadoop Catalog.
-->
it doesn't rely on the metastore to provide the actual URI when using the Hadoop Catalog.

yingsu00 · 2023-08-17T01:01:36Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+    To use Hadoop catalog with Iceberg table, it requires the ``hive.metastore.uri`` property, even
+    though it doesn't rely on metastore for metadata when using Hadoop Catalog. You can provide
+    a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will be fixed in a


YOu can provide a placeholder with ...
-->
You can provide any value to this property, for example, hive.metastore.uri=thrift://localhost:9083.

yingsu00 · 2023-08-17T01:04:58Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+-----------
+
+The Iceberg connector supports querying and manipulating Iceberg tables and schemas
+(databases). Here are the examples of SQL Operations supported from Presto :


Here are the examples of SQL Operations supported from Presto :
-->
Here are some examples of the SQL operations supported by Presto :

yingsu00 · 2023-08-17T01:09:29Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+* ``Bucket`` (partitions data into a specified number of buckets using a hash function)
+* ``Truncate`` (partitions the table based on the truncated value of the field, and can specify the width of truncated value)
+
+Create a Iceberg table partitioned into 8 buckets of equal sized ranges::


a Iceberg
-->
an Iceberg

Replace other 4 places too.

yingsu00 · 2023-08-17T01:10:44Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+^^^^^^^^^^^^^
+
+Create a new Iceberg table named ``page_views`` in the ``web`` schema
+that is stored using the ORC file format, partitioned by date and


partitioned by date and country
--->
partitioned by ds and country

yingsu00 · 2023-08-17T01:13:43Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+.. note::
+
+    ``Day``, ``Month``, ``Year``, ``Hour`` based partition column transform is not supported in Presto


Day, Month, Year, Hour based partition column transform is not supported in Presto Iceberg connector
-->
Day, Month, Year, Hour partition column transform functions are not supported in Presto Iceberg connector yet

yingsu00 · 2023-08-17T01:18:24Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+    To use Hadoop catalog with Iceberg table, it requires the ``hive.metastore.uri`` property, even
+    though it doesn't rely on metastore for metadata when using Hadoop Catalog. You can provide
+    a placeholder with ``hive.metastore.uri=thrift://localhost:9083``. This will be fixed in a
+    future release of Presto (:issue:`20579`).


@agrawalreetika Can you please double check if this issue display is correct? It shows up as this picture in my browser

Verified, after compiling on web UI it's showing correct issue link -

yingsu00 · 2023-08-17T01:26:55Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+
+.. note::
+
+    Iceberg Tables with format version 2 where delete files are present are not filtered in ``SELECT``


Iceberg Tables with format version 2 where delete files are present are not filtered in SELECT operations in Presto, and which will produce wrong results without filtering.
-->
The SELECT operations on Iceberg Tables with format version 2 do not read the delete files and remove the deleted rows as of now.

Please update the last section too.

yingsu00

@agrawalreetika Reetika, thanks for updating the PR so quickly. There are still some minor English grammar issues. Since I'm not a native speaker, I may not be able to identify them all. Will you be able to use some online grammar checker to double check the doc? @tdcmeehan will you be able to give it a final review as well?

yingsu00 · 2023-08-18T05:42:54Z

presto-docs/src/main/sphinx/connector/iceberg.rst

-------------
+Metastores
+-----------
+Iceberg tables stores most of the metadata in the metadata files along with the data on the


Iceberg tables stores
-->
Iceberg tables store

yingsu00 · 2023-08-18T05:44:02Z

presto-docs/src/main/sphinx/connector/iceberg.rst


 To configure the Iceberg connector, create a catalog properties file
-``etc/catalog/iceberg.properties`` with the following contents,
-replacing the properties as appropriate:
+``etc/catalog/iceberg.properties``. To define catalog type, ``iceberg.catalog.type`` property is


To define catalog type,
-->
To define the catalog type,

yingsu00 · 2023-08-18T05:58:59Z

presto-docs/src/main/sphinx/connector/iceberg.rst

+Hadoop catalog
+^^^^^^^^^^^^^^
+
+Iceberg connector supports Hadoop as Catalog


Iceberg connector supports Hadoop as Catalog
-->
Iceberg connector supports Hadoop catalog

agrawalreetika · 2023-08-18T06:54:00Z

@agrawalreetika Reetika, thanks for updating the PR so quickly. There are still some minor English grammar issues. Since I'm not a native speaker, I may not be able to identify them all. Will you be able to use some online grammar checker to double check the doc? @tdcmeehan will you be able to give it a final review as well?

Sure, let me go through it again what all I could find. These could probably be there since some of the portion is copy pasted from the existing document and I might have missed checking those.

agrawalreetika · 2023-08-18T08:54:11Z

@yingsu00 @tdcmeehan, I went through the full document to verify English grammar-related issues as Ying mentioned. I found a few which I have updated. Please review the changes.

tdcmeehan

Not gonna let the perfect be the enemy of the good. This is a fantastic next step to our documentation and I think we can merge ASAP. Thanks @agrawalreetika !

agrawalreetika requested a review from a team as a code owner August 11, 2023 08:13

agrawalreetika requested a review from presto-oss August 11, 2023 08:13

tdcmeehan requested a review from steveburnett August 11, 2023 13:54

tdcmeehan reviewed Aug 11, 2023

View reviewed changes

yingsu00 reviewed Aug 12, 2023

View reviewed changes

yingsu00 added the iceberg Apache Iceberg related label Aug 12, 2023

agrawalreetika force-pushed the iceberg-docs branch from b75bc4c to b94c752 Compare August 12, 2023 10:09

steveburnett approved these changes Aug 14, 2023

View reviewed changes

presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved

presto-docs/src/main/sphinx/connector/iceberg.rst Outdated Show resolved Hide resolved

agrawalreetika force-pushed the iceberg-docs branch from b94c752 to 2fc8f8b Compare August 14, 2023 19:47

yingsu00 reviewed Aug 15, 2023

View reviewed changes

yingsu00 requested a review from ChunxuTang August 15, 2023 01:14

ChunxuTang reviewed Aug 15, 2023

View reviewed changes

agrawalreetika force-pushed the iceberg-docs branch from 2fc8f8b to 3dd38a0 Compare August 15, 2023 20:24

steveburnett reviewed Aug 15, 2023

View reviewed changes

agrawalreetika force-pushed the iceberg-docs branch 2 times, most recently from e104d1f to 4b4d325 Compare August 16, 2023 05:58

agrawalreetika self-assigned this Aug 16, 2023

yingsu00 reviewed Aug 17, 2023

View reviewed changes

agrawalreetika force-pushed the iceberg-docs branch from 4b4d325 to 9e9a9f6 Compare August 17, 2023 06:30

yingsu00 reviewed Aug 18, 2023

View reviewed changes

Refactor existing & add new details in Iceberg document

d9015e6

agrawalreetika force-pushed the iceberg-docs branch from 9e9a9f6 to d9015e6 Compare August 18, 2023 08:44

tdcmeehan approved these changes Aug 18, 2023

View reviewed changes

ChunxuTang approved these changes Aug 18, 2023

View reviewed changes

yingsu00 approved these changes Aug 19, 2023

View reviewed changes

yingsu00 merged commit fea80c9 into prestodb:master Aug 19, 2023
50 checks passed

agrawalreetika deleted the iceberg-docs branch August 23, 2023 18:48

	But to store small amount of metadata it still requires Metastore to find the current location of the current
	But to store small amount of metadata it still requires a central place to find the current location of the current

	metadata pointer for a table. This central place is called ``Iceberg Catalog``.
	metadata pointer for a table. This central place is called the ``Iceberg Catalog``.

		@@ -11,12 +11,17 @@ The Iceberg connector allows querying data stored in Iceberg tables.

		It is recommended to use Iceberg 0.9.0 or later.


		.. note::

		To use Hadoop as catalog with Iceberg table requires the hive.metastore.uri property, even

		@@ -48,8 +49,16 @@ Nessie catalog
		^^^^^^^^^^^^^^

		In order to use a Nessie catalog, ensure to configure the catalog type with


		.. note::

		``Day``, ``Month``, ``Year``, ``Hour`` based partition column transform is not supported in Presto

Refactor existing & add new details in Iceberg document #20552

Refactor existing & add new details in Iceberg document #20552

Conversation

agrawalreetika commented Aug 11, 2023

Description

Motivation and Context

Impact

Test Plan

Contributor checklist

Release Notes

github-actions bot commented Aug 11, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yingsu00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrawalreetika Aug 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrawalreetika commented Aug 12, 2023

steveburnett left a comment

Choose a reason for hiding this comment

yingsu00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrawalreetika Aug 15, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrawalreetika commented Aug 15, 2023

ChunxuTang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

agrawalreetika commented Aug 15, 2023

Choose a reason for hiding this comment

yingsu00 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Aug 11, 2023 •

edited

Loading

agrawalreetika Aug 12, 2023 •

edited

Loading

agrawalreetika Aug 15, 2023 •

edited

Loading