Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "native_expression.max_array_size_in_reduce" session property. #23846

Conversation

spershin
Copy link
Contributor

Description

Add "native_expression.max_array_size_in_reduce" session property.
It can be used to control the limitation of Prestissimo's implementation of reduce() function.

== NO RELEASE NOTE ==

@spershin spershin requested review from steveburnett, elharo and a team as code owners October 16, 2024 17:44
@spershin spershin force-pushed the AddSessionProp_native_expression.max_array_size_in_reduce branch from 7518ddf to 9f7e71e Compare October 16, 2024 18:11
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc! Two suggestions.

@spershin spershin force-pushed the AddSessionProp_native_expression.max_array_size_in_reduce branch from 9f7e71e to 9526f85 Compare October 16, 2024 19:36
@spershin spershin requested a review from steveburnett October 16, 2024 19:37
feilong-liu
feilong-liu previously approved these changes Oct 16, 2024
@spershin spershin force-pushed the AddSessionProp_native_expression.max_array_size_in_reduce branch from 9526f85 to c099fe4 Compare October 16, 2024 20:42
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull updated branch, new local doc build, tested and verified link in doc. Thanks!

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spershin

@amitkdutta amitkdutta merged commit 61f5c3e into prestodb:master Oct 17, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants