Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native_expression.max_array_size_in_reduce session property #23856

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

pdabre12
Copy link
Contributor

Fixes a bug where users weren't able to set native_expression.max_array_size_in_reduce session property.
If there are two parts in the session property name, the first part is considered as the catalog.

presto> show session like 'native_expression%';
                    Name                    | Value  | Default |  Type   |                                                       Description                             >
--------------------------------------------+--------+---------+---------+----------------------------------------------------------------------------------------------->
 native_expression.max_array_size_in_reduce | 100000 | 100000  | integer | Native Execution only. Reduce() function will throw an error if it encounters an array of size>
(1 row)

presto> set session native_expression.max_array_size_in_reduce=50000;
Query 20241018_045451_00001_vgykq failed: line 1:1: Catalog native_expression does not exist
set session native_expression.max_array_size_in_reduce=50000

After fixing:

presto> show session like 'native_expression%';
                    Name                    | Value  | Default |  Type   |                                                       Description                             >
--------------------------------------------+--------+---------+---------+----------------------------------------------------------------------------------------------->
 native_expression_max_array_size_in_reduce | 100000 | 100000  | integer | Native Execution only. Reduce() function will throw an error if it encounters an array of size>
(1 row)

presto> set session native_expression_max_array_size_in_reduce=50000;
SET SESSION
presto> show session like 'native_expression%';
                    Name                    | Value | Default |  Type   |                                                       Description                              >
--------------------------------------------+-------+---------+---------+------------------------------------------------------------------------------------------------>
 native_expression_max_array_size_in_reduce | 50000 | 100000  | integer | Native Execution only. Reduce() function will throw an error if it encounters an array of size >
(1 row)
presto>

@pdabre12 pdabre12 marked this pull request as ready for review October 18, 2024 09:11
@pdabre12 pdabre12 requested review from steveburnett, elharo and a team as code owners October 18, 2024 09:11
elharo
elharo previously approved these changes Oct 18, 2024
steveburnett
steveburnett previously approved these changes Oct 18, 2024
Copy link
Contributor

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch, local doc build, looks good. Thanks!

@tdcmeehan
Copy link
Contributor

CC @spershin @amitkdutta

Copy link
Contributor

@amitkdutta amitkdutta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @pdabre12 for fixing it. Meta is not using it yet in production config explicity from deployment scripts. No risk on renaming it inline from this end.

@tdcmeehan tdcmeehan merged commit 0c19d4f into prestodb:master Oct 18, 2024
59 checks passed
@pdabre12 pdabre12 deleted the fix-session-property branch October 18, 2024 18:12
@jaystarshot jaystarshot mentioned this pull request Nov 1, 2024
25 tasks
@jaystarshot
Copy link
Member

Please consider adding release notes following our release notes guide - link.

Using below for now

* Fix a bug where users weren't able to set `native_expression.max_array_size_in_reduce` session property. :pr:`23856`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants