From db516855e238239f1e87dbac7afb8602d5fff0a5 Mon Sep 17 00:00:00 2001 From: Pratik Joseph Dabre Date: Fri, 18 Oct 2024 09:53:47 -0700 Subject: [PATCH] Fix native_expression.max_array_size_in_reduce session property --- .../main/java/com/facebook/presto/SystemSessionProperties.java | 2 +- presto-native-execution/presto_cpp/main/SessionProperties.h | 2 +- .../presto_cpp/main/tests/QueryContextManagerTest.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java b/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java index 1afdd169ba5e..2981ec7a8683 100644 --- a/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java +++ b/presto-main/src/main/java/com/facebook/presto/SystemSessionProperties.java @@ -335,7 +335,7 @@ public final class SystemSessionProperties // TODO: Native execution related session properties that are temporarily put here. They will be relocated in the future. public static final String NATIVE_SIMPLIFIED_EXPRESSION_EVALUATION_ENABLED = "native_simplified_expression_evaluation_enabled"; - public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression.max_array_size_in_reduce"; + public static final String NATIVE_EXPRESSION_MAX_ARRAY_SIZE_IN_REDUCE = "native_expression_max_array_size_in_reduce"; public static final String NATIVE_AGGREGATION_SPILL_ALL = "native_aggregation_spill_all"; public static final String NATIVE_MAX_SPILL_LEVEL = "native_max_spill_level"; public static final String NATIVE_MAX_SPILL_FILE_SIZE = "native_max_spill_file_size"; diff --git a/presto-native-execution/presto_cpp/main/SessionProperties.h b/presto-native-execution/presto_cpp/main/SessionProperties.h index e911aa6016bd..86ad349918c5 100644 --- a/presto-native-execution/presto_cpp/main/SessionProperties.h +++ b/presto-native-execution/presto_cpp/main/SessionProperties.h @@ -80,7 +80,7 @@ class SessionProperties { /// Reduce() function will throw an error if it encounters an array of size /// greater than this value. static constexpr const char* kExprMaxArraySizeInReduce = - "native_expression.max_array_size_in_reduce"; + "native_expression_max_array_size_in_reduce"; /// The maximum memory used by partial aggregation when data reduction is not /// optimal. diff --git a/presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp b/presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp index 14f1a7e87031..7a686d33d179 100644 --- a/presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp +++ b/presto-native-execution/presto_cpp/main/tests/QueryContextManagerTest.cpp @@ -58,7 +58,7 @@ TEST_F(QueryContextManagerTest, nativeSessionProperties) { {"native_debug_disable_expression_with_lazy_inputs", "true"}, {"native_selective_nimble_reader_enabled", "true"}, {"aggregation_spill_all", "true"}, - {"native_expression.max_array_size_in_reduce", "99999"}, + {"native_expression_max_array_size_in_reduce", "99999"}, }}; auto queryCtx = taskManager_->getQueryContextManager()->findOrCreateQueryCtx( taskId, session);