Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bank accounts #58

Closed
jo47011 opened this issue Jan 8, 2025 · 3 comments
Closed

Multiple bank accounts #58

jo47011 opened this issue Jan 8, 2025 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@jo47011
Copy link

jo47011 commented Jan 8, 2025

Hi,
first of all a big thanks for that great package 👍

One of my customer has multiple bank accounts where his customer can send the money to. As of my understanding of the code this is currently not possible. We would need to change the code like this (draft only):

class TradeSettlement(Element):
    ...
    payment_means = MultiField(PaymentMeans, required=False, profile=EXTENDED)

Or something like this. Does this makes sense?
If you agree I could try to dig into it to get it working and open a PR.

Or do I miss something and assigning multiple seller bank accounts is possible out of the box?

@mconstabel
Copy link

Hi,

from me also thanks for this helpful package :)

I also tried this and it worked only with

doc.trade.settlement.payment_means.type_code = "58"
doc.trade.settlement.payment_means.information.add("foo")
doc.trade.settlement.payment_means.payee_account.iban   = "DE1000"

But SpecifiedTradeSettlementPaymentMeans should be a list according to EN 16931?

So it should work as

payment_means = PaymentMeans()
payment_means.type_code = "58"
doc.trade.settlement.payment_means.add(payment_means)

?

@raphaelm
Copy link
Member

Happy to accept a PR!

@raphaelm raphaelm added the help wanted Extra attention is needed label Jan 22, 2025
@jo47011
Copy link
Author

jo47011 commented Jan 29, 2025

Done: see #67

@jo47011 jo47011 closed this as completed Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants