Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High-Res Skins #2

Open
preyneyv opened this issue Dec 4, 2021 · 1 comment
Open

High-Res Skins #2

preyneyv opened this issue Dec 4, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@preyneyv
Copy link
Owner

preyneyv commented Dec 4, 2021

https://www.reddit.com/r/leagueoflegends/comments/r7c0ir/i_made_skin_explorer_an_online_skin_splash_art/hmzm50g/
https://www.reddit.com/r/leagueoflegends/comments/r7c0ir/i_made_skin_explorer_an_online_skin_splash_art/hmzry5f/
https://www.reddit.com/r/leagueoflegends/comments/r7c0ir/i_made_skin_explorer_an_online_skin_splash_art/hn1t8uy/
@preyneyv preyneyv added the enhancement New feature or request label Feb 10, 2022
@preyneyv
Copy link
Owner Author

This is now possible!

https://cloud.google.com/vision/docs/detecting-web.

The plan is to update the scraper to run GCVision calls for all new images, then compress them to AVIF and serve them from S3/Cloudfront.

Unfortunately some results will be AI-upscaled but there's no easy way to detect that. This is better than nothing.

Original HD images are ~5MB which would be cost-prohibitive. Lossy AVIF compression can bring it down to <300KB (with chroma subsampling), but we also lose Edge support for HD images (licensing issues). Edge will continue getting the current skin images from CDragon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@preyneyv