Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message: New severity not reflected in styles #15534

Closed
EinfachHans opened this issue May 10, 2024 · 6 comments · Fixed by #15928
Closed

Message: New severity not reflected in styles #15534

EinfachHans opened this issue May 10, 2024 · 6 comments · Fixed by #15928
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@EinfachHans
Copy link

Describe the bug

In #15471 new severity options were added. For the message component they were named differently before and the changes were not applied to the styles. The error and warn options are removed, but still used for styles in all the theme files. So the new danger and warning have no styling.

Environment

//

Reproducer

No response

Angular version

17.3.8

PrimeNG version

17.16.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.12.2

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@EinfachHans EinfachHans added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 10, 2024
@Shusty-6th
Copy link

After updating primeNg to the new version, we have the same problem. I can see that for message severity error is no longer supported and instead takes danger, however the component displays badly because the theme css message still uses error and not danger.

@Rotzbua
Copy link
Contributor

Rotzbua commented May 14, 2024

With typescript it leads to an compile error:

error TS2322: Type '"error"' is not assignable to type '"success" | "info" | "warning" | "danger" | "help" | "primary" | "secondary" | "contrast" | null | undefined'.
<p-message severity="error"

@vinishiru
Copy link

Temporary solution for typescript that corrects the style, but displays an exclamation icon instead of times icon.

[severity]="$any('error')"

@thetric
Copy link

thetric commented Jun 13, 2024

This is really annoying and concerns every component with a severity input. This is a really annoying breaking change in a minor release :(

@meriturva
Copy link

Related to primefaces/primeng-sass-theme#134

chris-stillwell pushed a commit to chris-stillwell/primeng-style-fix that referenced this issue Jun 25, 2024
@cetincakiroglu cetincakiroglu added this to the 17.18.3 milestone Jul 1, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 1, 2024
@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Jul 1, 2024

Hi all,

As of 17.18.0, correct severity options for the message and toast components should be as follows:

severity: 'success' | 'info' | 'warn' | 'error' | 'secondary' | 'contrast' | undefined;

Possibly, this issue stems from a problem occurring when merging branches. We'll address the issue in 17.18.3 this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
7 participants