Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16793 - RTL Support #16799

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Fixed #16793 - RTL Support #16799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2092bc3
Fixed #16793 - RTL Support
tugcekucukoglu Nov 20, 2024
a678127
Refactor #16799 - showcase updates
tugcekucukoglu Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/showcase/assets/styles/layout/_code.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ code[class*="language-"],
pre[class*="language-"] {
background: none;
font-family: ui-monospace,SFMono-Regular,"SF Mono",Menlo,Consolas,Liberation Mono,monospace;
text-align: left;
text-align: start;
white-space: pre;
word-spacing: normal;
word-break: normal;
Expand Down
8 changes: 4 additions & 4 deletions apps/showcase/assets/styles/layout/_config.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
padding: 0.5rem 1rem;

&:first-child {
border-top-left-radius: 6px;
border-bottom-left-radius: 6px;
border-start-start-radius: 6px;
border-end-start-radius: 6px;
}

&:last-child {
border-top-right-radius: 6px;
border-bottom-right-radius: 6px;
border-start-end-radius: 6px;
border-end-end-radius: 6px;
}
}
}
Expand Down
28 changes: 15 additions & 13 deletions apps/showcase/assets/styles/layout/_doc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@
transition: outline-color 0.2s, border-color 0.2s;
outline-color: transparent;
border-bottom: 1px solid transparent;
border-top-right-radius: 6px;
border-top-left-radius: 6px;
border-start-end-radius: 6px;
border-start-start-radius: 6px;
white-space: nowrap;
--p-focus-ring-offset: -1px;
@include focus-visible();
Expand Down Expand Up @@ -114,7 +114,7 @@
> a {
color: var(--primary-text-color);
opacity: 0.7;
margin-left: 1rem;
margin-inline-start: 1rem;
display: none;
transition: outline-color 0.2s, border-color 0.2s, opacity 0.2s;
outline-color: transparent;
Expand All @@ -123,7 +123,7 @@
}

> .doc-section-label-badge {
margin-left: 0.5rem;
margin-inline-start: 0.5rem;
}

&:has(.doc-section-label-badge) {
Expand Down Expand Up @@ -177,20 +177,21 @@
max-height: calc(100vh - 15rem);
list-style: none;
margin: 0;
padding: 0.25rem 0;
margin-left: 4rem;
padding-block: 0.25rem;
padding-inline: 0;
margin-inline-start: 4rem;
overflow-y: auto;
overflow-x: hidden;
align-self: flex-start;

> .navbar-item {
.navbar-item-content {
border-left: 1px solid var(--border-color);
padding-left: .25rem;
border-inline-start: 1px solid var(--border-color);
padding-inline-start: .25rem;
transition: all .2s;

&:hover {
border-left-color: var(--hover-border-color);
border-inline-start-color: var(--hover-border-color);
}
}
}
Expand All @@ -201,11 +202,12 @@

button {
font-size: 1rem;
text-align: left;
text-align: start;
background: transparent;
margin: 0;
border: 0 none;
padding: 0.25rem 1rem 0.25rem 1rem;
padding-block: 0.25rem;
padding-inline: 1rem;
color: var(--text-secondary-color);
white-space: nowrap;
min-width: 0;
Expand Down Expand Up @@ -243,7 +245,7 @@

.navbar-item {
.navbar-item-content {
padding-left: 1rem;
padding-inline-start: 1rem;
}
}
}
Expand Down Expand Up @@ -326,7 +328,7 @@
th {
border-bottom: 1px solid var(--border-color);
padding: .75rem 1rem;
text-align: left;
text-align: start;
text-transform: capitalize;
}

Expand Down
4 changes: 2 additions & 2 deletions apps/showcase/assets/styles/layout/_responsive.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
}

@media screen and (max-width: 1199px) {
.layout-topbar-inner {
.layout-topbar-inner {
padding-left: 2rem;
padding-right: 2rem;

Expand Down Expand Up @@ -174,4 +174,4 @@
display: none;
}
}
}
}
35 changes: 20 additions & 15 deletions apps/showcase/assets/styles/layout/_sidebar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
.layout-sidebar {
position: sticky;
left: 0;
inset-inline-start: 0;
top: 6rem;
height: calc(100vh - 9rem);
user-select: none;
transition: transform .4s cubic-bezier(.05,.74,.2,.99), opacity .3s;
display: flex;
flex-direction: column;
padding: 0 0 0 0;
padding: 0;
flex: 0 0 250px;
margin-right: 4rem;
margin-inline-end: 4rem;
overflow: auto;

.logo {
Expand All @@ -18,7 +18,8 @@
}

nav {
padding: 0 1rem 0 0;
padding-block: 0;
padding-inline: 1rem 0;
margin: 0;
flex-grow: 1;
}
Expand All @@ -36,7 +37,8 @@
display: flex;
width: 100%;
align-items: center;
padding: .5rem 1px;
padding-block: .5rem;
padding-inline: 1px;
color: var(--text-color);
font-weight: 600;
transition: outline-color 0.2s;
Expand All @@ -46,7 +48,7 @@
font-size: 1rem;
border: 0 none;
margin: 0;
text-align: left;
text-align: start;
cursor: pointer;
user-select: none;
--p-focus-ring-offset: -1px;
Expand All @@ -56,7 +58,7 @@
width: 2rem;
height: 2rem;
border-radius: 6px;
margin-right: .5rem;
margin-inline-end: .5rem;
border: 1px solid var(--border-color);
display: inline-flex;
align-items: center;
Expand All @@ -73,7 +75,7 @@

.menu-toggle-icon {
color: var(--text-secondary-color);
margin-left: auto;
margin-inline-start: auto;
}

&:hover {
Expand Down Expand Up @@ -105,18 +107,20 @@
overflow: hidden;

ol {
margin: 0 0 0 1rem;
margin-block: 0;
margin-inline: 0 1rem;
padding: .25rem 0;
list-style: none;

li {
a {
border-left: 1px solid var(--border-color);
border-inline-start: 1px solid var(--border-color);
transition: all .2s;
font-weight: 450;
display: flex;
align-items: center;
padding: .5rem .5rem .5rem 1rem;
padding: .5rem;
padding-inline-start: 1rem;
color: var(--text-secondary-color);
transition: outline-color 0.2s, border-color .2s;
outline-color: transparent;
Expand All @@ -125,12 +129,12 @@
@include focus-visible();

&:hover {
border-left-color: var(--hover-border-color);
border-inline-start-color: var(--hover-border-color);
}

&.router-link-active {
color: var(--primary-text-color);
border-left-color: var(--primary-text-color);
border-inline-start-color: var(--primary-text-color);
}
}

Expand All @@ -153,7 +157,7 @@

.p-tag {
position: absolute;
right: 0;
inset-inline-end: 0;
top: 50%;
transform: translateY(-50%);

Expand All @@ -164,7 +168,8 @@

.menu-child-category {
display: flex;
padding: .5rem .5rem .5rem 0;
padding: .5rem;
padding-inline-start: 0;
font-size: .875rem;
font-weight: 600;
letter-spacing: 1px;
Expand Down
2 changes: 1 addition & 1 deletion apps/showcase/assets/styles/layout/_topbar.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

.layout-topbar-logo-container {
width: 250px;
margin-right: 4rem;
margin-inline-end: 4rem;
}

.layout-topbar-logo,
Expand Down
18 changes: 9 additions & 9 deletions apps/showcase/assets/styles/layout/layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ input[type=number]::-webkit-outer-spin-button, input[type=number]::-webkit-inner
.px-link {
font-size: 1rem;
border-radius: var(--border-radius);
text-align: left;
text-align: start;
background-color: transparent;
margin: 0;
padding: 0;
Expand Down Expand Up @@ -598,12 +598,12 @@ button {
padding: 0.5rem 1rem;
}
.layout-config .p-selectbutton .p-button:first-child {
border-top-left-radius: 6px;
border-bottom-left-radius: 6px;
border-start-start-radius: 6px;
border-end-start-radius: 6px;
}
.layout-config .p-selectbutton .p-button:last-child {
border-top-right-radius: 6px;
border-bottom-right-radius: 6px;
border-start-end-radius: 6px;
border-end-end-radius: 6px;
}
.layout-config button:focus-visible {
outline: 0 none;
Expand Down Expand Up @@ -632,7 +632,7 @@ code[class*=language-],
pre[class*=language-] {
background: none;
font-family: ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, Liberation Mono, monospace;
text-align: left;
text-align: start;
white-space: pre;
word-spacing: normal;
word-break: normal;
Expand Down Expand Up @@ -784,8 +784,8 @@ pre[class*=language-] code {
margin: 0;
transition: all 0.2s;
border-bottom: 1px solid transparent;
border-top-right-radius: var(--border-round);
border-top-left-radius: var(--border-round);
border-start-end-radius: var(--border-round);
border-start-start-radius: var(--border-round);
white-space: nowrap;
}
.doc-tabmenu li button:hover {
Expand Down Expand Up @@ -1006,7 +1006,7 @@ pre[class*=language-] code {
.doc-table th {
border-bottom: 1px solid var(--surface-border);
padding: 0.75rem 1rem;
text-align: left;
text-align: start;
text-transform: capitalize;
}
.doc-table tbody tr:hover {
Expand Down
16 changes: 9 additions & 7 deletions apps/showcase/components/doc/app.code.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,40 +57,42 @@ import { useCodeSandbox, useStackBlitz } from './codeeditor';
</button>
</div>

<pre *ngIf="lang === 'basic' && importCode" class="language-javascript"><code #codeElement>
<div dir="ltr">
<pre *ngIf="lang === 'basic' && importCode" class="language-javascript"><code #codeElement>
{{code.basic}}

</code></pre>

<pre *ngIf="lang === 'basic' && !importCode" class="language-markup"><code #codeElement>
<pre *ngIf="lang === 'basic' && !importCode" class="language-markup"><code #codeElement>
{{code.basic}}

</code></pre>

<pre *ngIf="lang === 'html'" class="language-markup"><code #codeElement>
<pre *ngIf="lang === 'html'" class="language-markup"><code #codeElement>
{{code.html}}

</code></pre>

<pre *ngIf="lang === 'typescript'" class="language-typescript"><code #codeElement>
<pre *ngIf="lang === 'typescript'" class="language-typescript"><code #codeElement>
{{code.typescript}}

</code></pre>

<pre *ngIf="lang === 'data'" class="language-json"><code #codeElement>
<pre *ngIf="lang === 'data'" class="language-json"><code #codeElement>
{{code.data}}

</code></pre>

<pre *ngIf="lang === 'scss'" class="language-scss"><code #codeElement>
<pre *ngIf="lang === 'scss'" class="language-scss"><code #codeElement>
{{code.scss}}

</code></pre>

<pre *ngIf="lang === 'command'" class="language-shell"><code #codeElement>
<pre *ngIf="lang === 'command'" class="language-shell"><code #codeElement>
{{code.command}}

</code></pre>
</div>
</div>
`
})
Expand Down
2 changes: 1 addition & 1 deletion apps/showcase/pages/landing/blocksection.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { Component } from '@angular/core';
<div class="flex justify-center mt-6 relative z-30">
<a href="https://blocks.primeng.org" target="_blank" class="linkbox linkbox-primary">
<span>Explore All</span>
<i class="pi pi-arrow-right ml-2"></i>
<i class="pi pi-arrow-right ms-2"></i>
</a>
</div>
<section class="prime-blocks blocks-animation flex justify-center items-center flex-col">
Expand Down
Loading
Loading