Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support RTL #85

Open
JolianGof opened this issue Nov 10, 2024 · 0 comments
Open

support RTL #85

JolianGof opened this issue Nov 10, 2024 · 0 comments

Comments

@JolianGof
Copy link

I have cloned the SAKAI template and added primereact-sass-theme to it. Even though primereact-sass-theme mostly supports RTL it does not do very well with margin, padding, and border-radius. I am trying to fix that by using the inline CSS property which is working fine. The problem I am facing is that when I inspect some components there are classes or CSS properties that are not in the primereact-sass-theme/components and are overriding the primereact-sass-theme/components styling and I can only apply the styling by using the !important or add the class to the primereact-sass-theme/components.

  • here is an example:
    1: I have a SelectButton component and when I inspect it this what I see:

Screenshot 2024-11-10 110524
as you can see in this picture the class .p-button:first-of-type does not exist in the primereact-sass-theme/components. So, I would have to add the class and also add the !important to override it.
like this

.p-button-group .p-button:first-of-type {
  
    border-start-start-radius: 10px !important;
    border-start-end-radius: 0 !important;
    border-end-end-radius: 0 !important;
    border-end-start-radius: 10px !important;
    border-right: $toggleButtonBorder !important;
}
  • there also many cases like this

is there a reason why this happens and if so how can I fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant