Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderList: filterPlaceholder prop does not work #7662

Closed
pintof opened this issue Jan 30, 2025 · 3 comments · Fixed by #7663
Closed

OrderList: filterPlaceholder prop does not work #7662

pintof opened this issue Jan 30, 2025 · 3 comments · Fixed by #7663
Assignees
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@pintof
Copy link

pintof commented Jan 30, 2025

Describe the bug

In the OrderList component, the filterPlaceholder prop does not work (it does not add any placeholder text on render)

Reproducer

https://stackblitz.com/edit/qdw7ced7?file=src%2FApp.jsx

System Information

System:
    OS: Windows 10 10.0.19045
    CPU: (4) x64 Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz
    Memory: 2.58 GB / 7.92 GB
  Binaries:
    Node: 23.6.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 11.0.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Chromium (128.0.2739.42)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    primereact: ^10.9.1 => 10.9.1
    react: ^19.0.0 => 19.0.0

Steps to reproduce the behavior

  1. Open the accompanied stackblitz link
  2. Observe that the filterPlaceholder prop in the OrderList component is assigned to a string, yet no text is present as placeholder text on render

Expected behavior

Placeholder text should be present, when the filterPlaceholder prop is assigned to a string.

@pintof pintof added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 30, 2025
melloware added a commit to melloware/primereact that referenced this issue Jan 30, 2025
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 30, 2025
@melloware melloware self-assigned this Jan 30, 2025
@melloware melloware added this to the 10.9.3 milestone Jan 30, 2025
@melloware
Copy link
Member

Thanks! Fixed for next release

@pintof
Copy link
Author

pintof commented Jan 31, 2025

Thanks @melloware

Also just discovered if you rename the prop 'filterPlaceholder' to 'placeholder' it works fine.
So you could alternatively update the documentation instead of the codebase (if thats a preferable route for you)

@melloware
Copy link
Member

Yep but I think the fix I made was more correct since other places use filterPlaceholder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants