-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#13] 토글 공통 컴포넌트 구현 #22
Open
chaduhwan
wants to merge
3
commits into
main
Choose a base branch
from
feat/#13
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
'use client' | ||
|
||
import * as Switch from '@radix-ui/react-switch' | ||
import { theme } from '@/styles/theme' | ||
import styled from 'styled-components' | ||
|
||
const StyledRoot = styled(Switch.Root)` | ||
width: 42px; | ||
height: 25px; | ||
background-color: ${theme.color.grey200}; | ||
border-radius: 9999px; | ||
position: relative; | ||
-webkit-tap-highlight-color: rgba(0, 0, 0, 0); | ||
|
||
&[data-state='checked'] { | ||
background-color: ${theme.color.purple700}; | ||
} | ||
` | ||
|
||
const ToggleRoot = ({ children, ...props }: Switch.PrimitiveButtonProps) => { | ||
return <StyledRoot {...props}>{children}</StyledRoot> | ||
} | ||
|
||
export default ToggleRoot |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use client' | ||
|
||
import * as Switch from '@radix-ui/react-switch' | ||
import { theme } from '@/styles/theme' | ||
import styled from 'styled-components' | ||
|
||
const StyledThumb = styled(Switch.SwitchThumb)` | ||
display: block; | ||
width: 21px; | ||
height: 21px; | ||
background-color: ${theme.color.white}; | ||
border-radius: 9999px; | ||
box-shadow: 0 2px 2px var(--black-a7); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 현재 여기 있는 --black-a7 변수는 제대로 적용되고 있는걸까요?? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 레퍼런스 하는 도중에 들억간거 같습니다. 수정하겠습니다 ! |
||
transition: transform 300ms; | ||
transform: translateX(2px); | ||
will-change: transform; | ||
|
||
&[data-state='checked'] { | ||
transform: translateX(19px); | ||
} | ||
` | ||
|
||
const ToggleThumb = ({ ...props }: Switch.SwitchThumbProps) => { | ||
return <StyledThumb {...props} /> | ||
} | ||
|
||
export default ToggleThumb |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
현재 radix 라이브러리를 전체를 가르키는 변수명을 [기능]Primitive 로 이름짓구 있습니다. SwitchPrimitive로 바꾸면 컨벤션을 유지 할 수 있을꺼같아요 !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 감사합니다 !!