Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Vercel's ncc #3662

Open
jkomyno opened this issue Jul 4, 2023 · 1 comment
Open

Test Vercel's ncc #3662

jkomyno opened this issue Jul 4, 2023 · 1 comment
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. topic: vercel

Comments

@jkomyno
Copy link
Contributor

jkomyno commented Jul 4, 2023

We currently test that Prisma + Vercel's pkg bundler work, but we don't have any test for ncc.
While pkg basically bundles everything it finds up, ncc bundles a Node.js codebase into a single artifact.
Vercel claims it supports Node.js binary addons (NAPI), but apparently napi.rs may not be supported (see a Prisma user comment on bundling libquery + ncc, which is apparently just fixed by using the binary Query Engine target prisma/prisma#16901 (comment)).

ncc may also be used by the Vercel CLI, so it's highly relevant for us to ensure this works.

Next steps:

@jkomyno jkomyno added bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. team/schema topic: vercel labels Jul 4, 2023
@jkomyno
Copy link
Contributor Author

jkomyno commented Jul 4, 2023

See more on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/1-unconfirmed Bug should have enough information for reproduction, but confirmation has not happened yet. kind/bug A reported bug. topic: vercel
Projects
None yet
Development

No branches or pull requests

2 participants