Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider modifying EqPolynomial new to force clone #47

Open
oskarth opened this issue Aug 1, 2023 · 0 comments
Open

Consider modifying EqPolynomial new to force clone #47

oskarth opened this issue Aug 1, 2023 · 0 comments

Comments

@oskarth
Copy link
Collaborator

oskarth commented Aug 1, 2023 •
edited
Loading

The to_vec forces the clone.
Can't we modify the fn signature then so that forces us to clone too? (So no reference)?? Otherwise, this looks like you just need a ref while in reality, is basically copying the entire vector inside.

Originally posted by @CPerezz in #42 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@oskarth