177 forward ip as client parameter to privacyidea #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
PrivacyIDEAAuthenticatorproject, focusing on adding new configuration options and improving existing functionality. The most important changes include updating dependencies, adding the ability to forward the client IP to privacyIDEA server, and fixing some minor issues.Dependency updates:
pom.xml: Updated thekeycloak-server-spi-privateandkeycloak-servicesdependencies to version 25.0.1.New features:
src/main/java/org/privacyidea/authenticator/Configuration.java: Added a new configuration optionforwardClientIPto forward the client IP address. [1] [2] [3]src/main/java/org/privacyidea/authenticator/Const.java: Added a constant for the new configuration optionCONFIG_FORWARD_CLIENT_IP.src/main/java/org/privacyidea/authenticator/PrivacyIDEAAuthenticator.java: Modified theloadConfigurationmethod to use theforwardClientIPconfiguration option.Bug fixes and improvements:
src/main/java/org/privacyidea/authenticator/PrivacyIDEAAuthenticator.java: Corrected the capitalization ofmultiChallengein several places. [1] [2] [3]src/main/resources/theme-resources/resources/js/pi-utils.js: Fixed thepiGetValuefunction to return the element's value if it is not null.