Skip to content

Commit

Permalink
Merge pull request #1376 from andyleiserson/chunk
Browse files Browse the repository at this point in the history
Revise comment about chunk override for attribution
  • Loading branch information
andyleiserson authored Oct 28, 2024
2 parents 631bfc3 + 554c891 commit 9dba1f6
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ipa-core/src/protocol/ipa_prf/prf_sharding/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,9 @@ where
protocol: &Step::Attribute,
validate: &Step::AttributeValidate,
},
// TODO: this should not be necessary, but probably can't be removed
// until we align read_size with the batch size.
// TODO: this override was originally added to work around problems with
// read_size vs. batch size alignment. Those are now fixed (in #1332), but this
// is still observed to help performance (see #1376), so has been retained.
std::cmp::min(sh_ctx.active_work().get(), chunk_size.next_power_of_two()),
);
dzkp_validator.set_total_records(TotalRecords::specified(histogram[1]).unwrap());
Expand Down

0 comments on commit 9dba1f6

Please sign in to comment.