Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

U128Conversion::truncate_from for fields has confusing behavior #1421

Open
akoshelev opened this issue Nov 8, 2024 · 0 comments
Open

U128Conversion::truncate_from for fields has confusing behavior #1421

akoshelev opened this issue Nov 8, 2024 · 0 comments

Comments

@akoshelev
Copy link
Collaborator

From discussions on #1409 - truncate_from originally meant dropping bits converting 16 bit values to fields, but evolved into modulo reduction operation. We should have a better name for this function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@akoshelev