Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure seq_join is called with an appropriate value for active_work #1499

Open
andyleiserson opened this issue Dec 14, 2024 · 0 comments
Open

Comments

@andyleiserson
Copy link
Collaborator

Historically, active_work was configured globally and had the same value everywhere.

Now, active_work is adjusted when creating a DZKP validator, to have an appropriate value relative to the batch size.

Unfortunately, seq_join is often invoked as a free function, like this: seq_join(ctx.active_work(), ...). If there are multiple contexts in scope (e.g. a non-upgraded ctx and a DZKP-upgraded m_ctx), the active work used for seq_join may not match the validator-adjusted value.

Assuming we can avoid the dreaded 100013-related errors, it might be better to invoke seq_join as a helper on the context, so that the appropriate active work can be used automatically. Although, that may not improve things that much, since one could still do ctx.seq_join(/* futures referencing m_ctx */).

In any case, filing this as a reminder to revisit this, possibly doing some refactoring, or maybe just auditing seq_join calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant