Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBM compatibility with LightGBM #68

Closed
nbenn opened this issue May 19, 2019 · 6 comments
Closed

FBM compatibility with LightGBM #68

nbenn opened this issue May 19, 2019 · 6 comments

Comments

@nbenn
Copy link

nbenn commented May 19, 2019

I'm trying to use an FBM matrix for training a LightGBM model (could probably also be done for xgboost in similar fashion). For this I think it's easiest (for dependencies sake) to pass a pointer to start of the data via R as an external pointer. I hacked something together:

https://github.com/nbenn/bigstatsr/blob/b668f2fdcfafbf1d280250bca9ca0cabaa88a855/src/FBM-xptr.cpp#L27-L35

How do you feel about this?

See also microsoft/LightGBM#2184.

@privefl
Copy link
Owner

privefl commented May 19, 2019

I mean, if it is as easy as that, why not.
I don't know about LightGBM, but XGBoost handles passing an external pointer? Is that new?

@privefl
Copy link
Owner

privefl commented Jun 16, 2019

Any update on this?

@privefl
Copy link
Owner

privefl commented Jan 14, 2020

Any update on this?

@nbenn
Copy link
Author

nbenn commented Jan 17, 2020

I'm sorry, I guess we can close this for now. As long as there is no support on the LightGBM side, there's no need for a getDataPtrFBM() function. While my idea did make the feature request list at microsoft/LightGBM#2302, there hasn't been much movement there.

@nbenn nbenn closed this as completed Jan 17, 2020
@privefl
Copy link
Owner

privefl commented Jan 17, 2020

Thanks for following up.

Just to make sure: it is on their side that some work needs to be done? Not on my side?

@nbenn
Copy link
Author

nbenn commented Jan 17, 2020

Yeah, so from what I remember, for this to work out, both a function for getting a pointer to the data as EXTPTRSXP and a way for LightGBM to make use of this pointer is needed. I put together a quick suggestion for them how this could be done, but never really got any feedback. So I guess, they're not really that interested (or it turns out to be move involved than I understand).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants