-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Join us page #47
Comments
There is also a problem with previewing special characters like * and ``. The original message was: 2 bugs:
|
@smcgregor I can take this up. Just need a little guidance. |
|
Taking this up then. Also markdown I used to generate my list: 2 bugs:
Do you want me to attach it? You can see it with the edit option though. |
I'm not having any issues rendering the markdown from GitHub. Maybe there is an unusual character in the non-github markdown? |
^ The `` for code doesn't get parsed. |
Can you reduce this to a minimal demonstration of the bug? I am still not entirely certain what you are trying to show me. Try removing all text except what is necessary to show the problem, then share with me the literal markdown version in something like pastebin and the rendered version from privlyalpha.org. Also please indicate whether you are talking about the version that is injected by an extension (tell me which extension), or the version that is shown when you click the link (and give the address of the page if it is the version after clicking the link). It would probably also be useful to share a screen capture annotated to point to the problem. |
I am so sorry. The following markdown contains `` for the coding part: |
It boils down to this: |
No need to apologize :) The screen capture below shows the HTMl for the injected content above. It is wrapping the code in the code block, but since the injected iframe does not inherit the stylesheets of GitHub it does not display code blocks the same as GitHub. You could propose to make injected Privly apps look more like Github by opening a pull request against this stylesheet, which determines how code is displayed injected via Privly. |
I didn't get you. By proposal you mean actually changing the code right and opening a PR against it? |
Yes. |
https://privlyalpha.org/apps/Message/show?privlyApp=Message&privlyInject1=true&random_token=11a6748755&privlyDataURL=https%3A%2F%2Fprivlyalpha.org%2Fposts%2F4784.json%3Frandom_token%3D11a6748755#privlyLinkKey=UORNT0OzCQPUoVPhCUK4fHAdbg1x6MzcF4CvLMh%2F0%2BQ%3D
The text was updated successfully, but these errors were encountered: