Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join us page #47

Open
prastut opened this issue Feb 27, 2016 · 14 comments
Open

Join us page #47

prastut opened this issue Feb 27, 2016 · 14 comments

Comments

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

There is also a problem with previewing special characters like * and ``. The original message was:

2 bugs:

  • I think you guys have done rerouting of the pages to make pretty urls. Taking inference that most pages that they don't show .html as extension in the end. But the join us on About page takes us to the .html page.
  • The title for the page contains a fa-fa font reference:

    <title>Privly · &lt;i class="fa fa-github"&gt;&lt;/i&gt; Open Source</title>

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

@smcgregor I can take this up. Just need a little guidance.

@smcgregor
Copy link
Member

  • The site is rendered by the static HTML generator Jekyll, which doesn't generate the pages with .html automatically. Our build script copies many of the .html files to not have the extension, which means we have two copies of the page but it works fine in practice. You can standardize the links to the non-".html" version of the link because it looks better, but I am not overly concerned by this.
  • Can you share the markdown used to generate your original list? I'll test it out.
  • That title issue is pretty bad. I usually have too many tabs open to view it. If you want to fix it, the appropriate file is here. You'll need to install Jekyll Bootstrap to build the site and test your solution.

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

Taking this up then. Also markdown I used to generate my list:

2 bugs:

  • I think you guys have done rerouting of the pages to make pretty urls. Taking inference that most pages that they don't show .html as extension in the end. But the join us on About page takes us to the .html page.
  • The title for the page contains a fa-fa font reference:

    <title>Privly · &lt;i class="fa fa-github"&gt;&lt;/i&gt; Open Source</title>

Do you want me to attach it? You can see it with the edit option though.

@smcgregor
Copy link
Member

I'm not having any issues rendering the markdown from GitHub. Maybe there is an unusual character in the non-github markdown?

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

^ The `` for code doesn't get parsed.

@smcgregor
Copy link
Member

Can you reduce this to a minimal demonstration of the bug? I am still not entirely certain what you are trying to show me. Try removing all text except what is necessary to show the problem, then share with me the literal markdown version in something like pastebin and the rendered version from privlyalpha.org. Also please indicate whether you are talking about the version that is injected by an extension (tell me which extension), or the version that is shown when you click the link (and give the address of the page if it is the version after clicking the link). It would probably also be useful to share a screen capture annotated to point to the problem.

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

I am so sorry. The following markdown contains `` for the coding part:
http://pastebin.com/5xhtQYHX

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

It boils down to this:
Type `` and use privly. It shows in github but doesn't show with privly preview.

@smcgregor
Copy link
Member

No need to apologize :)

The screen capture below shows the HTMl for the injected content above. It is wrapping the code in the code block, but since the injected iframe does not inherit the stylesheets of GitHub it does not display code blocks the same as GitHub. You could propose to make injected Privly apps look more like Github by opening a pull request against this stylesheet, which determines how code is displayed injected via Privly.

screen shot 2016-02-27 at 11 05 04 am

@prastut
Copy link
Contributor Author

prastut commented Feb 27, 2016

I didn't get you. By proposal you mean actually changing the code right and opening a PR against it?

@smcgregor
Copy link
Member

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants