From f13f26cf441e4182339faa2bc2b8347da77960c8 Mon Sep 17 00:00:00 2001 From: Jonathan Wenger Date: Wed, 8 Jul 2020 16:53:28 +0200 Subject: [PATCH] some review comments resolved --- src/probnum/linalg/linearsolvers/solutionbased.py | 2 -- src/probnum/prob/distributions/distribution.py | 2 +- src/probnum/prob/distributions/normal.py | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/probnum/linalg/linearsolvers/solutionbased.py b/src/probnum/linalg/linearsolvers/solutionbased.py index 453e89ccc..27170f596 100644 --- a/src/probnum/linalg/linearsolvers/solutionbased.py +++ b/src/probnum/linalg/linearsolvers/solutionbased.py @@ -68,8 +68,6 @@ def has_converged(self, iter, maxiter, resid=None, atol=None, rtol=None): return True, "resid_atol" elif np.linalg.norm(resid) <= rtol * np.linalg.norm(self.b): return True, "resid_rtol" - # uncertainty-based - # todo: based on posterior contraction else: return False, "" diff --git a/src/probnum/prob/distributions/distribution.py b/src/probnum/prob/distributions/distribution.py index 11157fcbb..41983609f 100644 --- a/src/probnum/prob/distributions/distribution.py +++ b/src/probnum/prob/distributions/distribution.py @@ -106,7 +106,7 @@ def _set_shape(self, shape): if shape is None or shape_sample == shape: self._shape = shape_sample else: - raise ValueError("Shape of distribution mean and given shape do not match.") + raise ValueError("Shape of distribution sample and given shape do not match.") @property def shape(self): diff --git a/src/probnum/prob/distributions/normal.py b/src/probnum/prob/distributions/normal.py index 7c3f0a182..5303676df 100644 --- a/src/probnum/prob/distributions/normal.py +++ b/src/probnum/prob/distributions/normal.py @@ -405,7 +405,7 @@ def sample(self, size=()): def reshape(self, newshape): raise NotImplementedError - # Arithmetic Operations ############################### + # Arithmetic Operations def __matmul__(self, other): """