Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience functions RandomVariable.var and RandomVariable.std #122

Closed
nathanaelbosch opened this issue Jul 24, 2020 · 2 comments · Fixed by #164
Closed

Convenience functions RandomVariable.var and RandomVariable.std #122

nathanaelbosch opened this issue Jul 24, 2020 · 2 comments · Fixed by #164
Assignees
Labels
feature request Requests for features to be implemented improvement Improvements of existing functionality randvars Issues related to random variables

Comments

@nathanaelbosch
Copy link
Collaborator

If we want to access the variance and standard deviation often, it might be useful to have those convenience functions. The naming could also be cov and std, which might be more in line with our current style.

EDIT: I just saw that Distribution has those functions. Then I guess my question is: Would it make sense to have those for RVs also? If not, what is the reasoning behind that?

@nathanaelbosch nathanaelbosch added question Further information is requested feature request Requests for features to be implemented improvement Improvements of existing functionality labels Jul 24, 2020
@JonathanWenger
Copy link
Contributor

Absolutely. I believe these may have even existed at some point and gotten refactored. I would suggest to have cov var and std such that cov returns the covariance, var its diagonal and std the square root of var. For univariate rvs cov and var return the same.

@nathanaelbosch nathanaelbosch added randvars Issues related to random variables and removed question Further information is requested labels Jul 28, 2020
@marvinpfoertner
Copy link
Collaborator

This issue should resolve itself if we decide to unify random variables and distributions, right? Relates to #131.

@JonathanWenger JonathanWenger changed the title Convenienve functions RandomVariable.var and RandomVariable.std Convenience functions RandomVariable.var and RandomVariable.std Aug 13, 2020
@marvinpfoertner marvinpfoertner self-assigned this Aug 17, 2020
@marvinpfoertner marvinpfoertner linked a pull request Aug 30, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for features to be implemented improvement Improvements of existing functionality randvars Issues related to random variables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants