Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis of type hints using mypy #702

Open
marvinpfoertner opened this issue Apr 12, 2022 · 0 comments
Open

Static analysis of type hints using mypy #702

marvinpfoertner opened this issue Apr 12, 2022 · 0 comments
Labels
feature request Requests for features to be implemented testing and CI Unit tests, coverage and continuous integration

Comments

@marvinpfoertner
Copy link
Collaborator

marvinpfoertner commented Apr 12, 2022

Is your feature request related to a problem? Please describe.
probnum uses type hints quite extensively. However, since we do not run any static analysis tool on them, they are very prone to errors.

Describe the solution you'd like.

  • add mypy to linting-requirements.txt and pin the major version number
  • add a mypy environment to the tox configuration (similar to the pylint environment)
  • add mypy configuration to the pyproject.toml file
  • add a mypy check to our GitHub Actions CI pipeline, initially only checking
    • probnum._function
    • probnum.pn_method

Additional context
None

@marvinpfoertner marvinpfoertner added feature request Requests for features to be implemented testing and CI Unit tests, coverage and continuous integration labels Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for features to be implemented testing and CI Unit tests, coverage and continuous integration
Projects
None yet
Development

No branches or pull requests

1 participant