Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if escape sequences are handled correctly #8

Open
gr2m opened this issue Apr 9, 2019 · 2 comments
Open

Check if escape sequences are handled correctly #8

gr2m opened this issue Apr 9, 2019 · 2 comments

Comments

@gr2m
Copy link
Contributor

gr2m commented Apr 9, 2019

This is a follow up for octokit/webhooks.js#71. It would be good to check if smee is lowercasing escape sequences before forward a webhook event.
@gimenete
Copy link

gimenete commented Apr 9, 2019

I think it is a bug doing any type of transformation. The payload should not be touched or any signature calculation from github could break as I mentioned here octokit/webhooks.js#71 (comment)

@gr2m
Copy link
Contributor Author

gr2m commented Apr 9, 2019

No intended transformation is done, but given that it’s happening with JSON.parse() I want to make sure that smee is not affected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gr2m @gimenete