Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Update Script to either use data-label or "real" label tag. #6

Open
derpoho opened this issue Dec 8, 2013 · 4 comments
Open

Update Script to either use data-label or "real" label tag. #6

derpoho opened this issue Dec 8, 2013 · 4 comments

Comments

@derpoho
Copy link
Collaborator

derpoho commented Dec 8, 2013

See #3 , #4 , #5 .

@perre
Copy link

perre commented May 19, 2014

I'm a UX looking to recommend this to our engineers, but can't do it unless it passes a standard accessibility test called WAVE. It sees the current demo's label as "missing". http://wave.webaim.org/report#/http%3A%2F%2Fclubdesign.github.io%2Ffloatlabels.js%2F
From reading #3 , #4 , #5 , I see that @joahg updated the live demo with the new syntax. But is adding the syntax different from deploying a "real" label tag model in the demo? Just looking for an example that passes WAVE. Thanks.

@joahg
Copy link

joahg commented May 19, 2014

Alright, cool @perre. It looks like my version passes the test fine in that regard. My PR (#4) was rejected, but it looks like it fixes the issue with floatlabels.js - can you confirm this?

@perre
Copy link

perre commented Aug 27, 2014

Thanks @joahg this is great.

@perre
Copy link

perre commented Aug 27, 2014

I'll be more clear: yes, it fixes the issue with the label not being recognized nor tied to the field. I suggest this tweak you made be incorporated into the official demo eventually.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants