Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Error in PR 2353 #2877

Closed
raclim opened this issue Jan 10, 2024 · 1 comment
Closed

Fix Error in PR 2353 #2877

raclim opened this issue Jan 10, 2024 · 1 comment
Labels

Comments

@raclim
Copy link
Collaborator

raclim commented Jan 10, 2024

Fix for Error Found in Comment in #2353:

@raclim there is definitely in a problem in the IDEOverlays. There is no this.state so projectId={this.state.sketchToAddToCollection.id} won't work. It looks like we want to keep the projectId={params.project_id} there and the only change to that file is to remove the line username={params.username}.

@raclim raclim added the Bug label Jan 10, 2024
@raclim
Copy link
Collaborator Author

raclim commented Jan 10, 2024

I ultimately didn't name the commit message properly (I was supposed to use "fixes #2877" instead of "fixes 2877") , but this commit resolves this issue.

@raclim raclim closed this as completed Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant