-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Sensitive Files Check and Health Check Script in CI #3399
Comments
Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already. |
@raclim can I work on this issue.. ? |
@raclim i am working on this issue |
Thanks for opening this! @shivasankaran18 and @ishwarthecodddr i think it’s best maybe to talk through some of the changes you’re hoping to implement first before working on it! Could you maybe provide a few more details? |
@raclim Developers might accidentally commit actual credentials, API keys, or passwords to the repository. Without proper monitoring, these secrets could be exposed publicly. Adding sensitive files to the CI checks could prevent this . |
@raclim Health check script to ensure deployment stability:
If it's all good , I can work on this issue with you approval |
@raclim any comments ..? Can I work on this issue |
Thanks so much for your suggestions! While we do have files that could contain sensitive information (such as . Given that, I feel like a CI check for unauthorized changes to these values are not needed right now, and could make it more difficult when we do need to update these files. We also have health checks that are handled by the platforms that we currently use to host the editor, so I don't think we may need a supplementary one here. I appreciate you taking the time to raise and think about this issue and how to implement security and robustness within the editor! Due to some of the reasons I outlined above, I'm going to close this for now, but I think this is something we could revisit if the scale/infrastructure of the project expands down the line! |
ok @raclim .. thanks for your review |
Increasing Access
Unsure
Feature request details
We need to enhance our CI pipeline by adding checks for sensitive files and a health check script to ensure deployment stability
Implement a CI step to check for unauthorized changes to sensitive files during pull requests and a health check script that verifies the application is running correctly on the specified port.
The text was updated successfully, but these errors were encountered: