Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Sensitive Files Check and Health Check Script in CI #3399

Closed
shivasankaran18 opened this issue Mar 16, 2025 · 9 comments
Closed

Comments

@shivasankaran18
Copy link

shivasankaran18 commented Mar 16, 2025

Increasing Access

Unsure

Feature request details

We need to enhance our CI pipeline by adding checks for sensitive files and a health check script to ensure deployment stability

Implement a CI step to check for unauthorized changes to sensitive files during pull requests and a health check script that verifies the application is running correctly on the specified port.

Copy link

welcome bot commented Mar 16, 2025

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@shivasankaran18
Copy link
Author

@raclim can I work on this issue.. ?

@ishwarthecodddr
Copy link

@raclim i am working on this issue

@raclim
Copy link
Collaborator

raclim commented Mar 16, 2025

Thanks for opening this! @shivasankaran18 and @ishwarthecodddr i think it’s best maybe to talk through some of the changes you’re hoping to implement first before working on it! Could you maybe provide a few more details?

@ishwarthecodddr
Copy link

@raclim Developers might accidentally commit actual credentials, API keys, or passwords to the repository. Without proper monitoring, these secrets could be exposed publicly. Adding sensitive files to the CI checks could prevent this .

@shivasankaran18
Copy link
Author

@raclim
Check for unauthorized changes to sensitive files during pull requests:
1.dentify which files are considered sensitive.
2. Implement a CI step to check for any changes to these files.
3. Ensure that if unauthorized changes are detected, the CI pipeline fails the pull request.

Health check script to ensure deployment stability:

  1. Create a script that verifies the application is running correctly.

If it's all good , I can work on this issue with you approval

@shivasankaran18
Copy link
Author

@raclim any comments ..? Can I work on this issue

@raclim
Copy link
Collaborator

raclim commented Mar 25, 2025

Thanks so much for your suggestions!

While we do have files that could contain sensitive information (such as .env), they are either meant to be ignored by using .gitignore or hold placeholder information—the actual secrets and credentials are not held within this repository.

Given that, I feel like a CI check for unauthorized changes to these values are not needed right now, and could make it more difficult when we do need to update these files. We also have health checks that are handled by the platforms that we currently use to host the editor, so I don't think we may need a supplementary one here.

I appreciate you taking the time to raise and think about this issue and how to implement security and robustness within the editor! Due to some of the reasons I outlined above, I'm going to close this for now, but I think this is something we could revisit if the scale/infrastructure of the project expands down the line!

@raclim raclim closed this as not planned Won't fix, can't repro, duplicate, stale Mar 25, 2025
@shivasankaran18
Copy link
Author

ok @raclim .. thanks for your review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants