Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Lazy Loading for React Components #3403

Open
shivasankaran18 opened this issue Mar 18, 2025 · 5 comments · May be fixed by #3420
Open

Implement Lazy Loading for React Components #3403

shivasankaran18 opened this issue Mar 18, 2025 · 5 comments · May be fixed by #3420

Comments

@shivasankaran18
Copy link

Increasing Access

Unsure

Feature enhancement details

Currently, the processing/p5.js-web-editor repository does not implement lazy loading for React components. Implementing lazy loading can improve the performance of the web editor by reducing the initial load time and loading components only when they are needed.

@shivasankaran18
Copy link
Author

@raclim what's your comments on this? ..
can I work on this issue.. ?

@Jatin24062005
Copy link
Contributor

Jatin24062005 commented Mar 18, 2025

@shivasankaran18 In the p5.js Web Editor, there isn't a dedicated image component that would directly benefit from lazy loading. Additionally, for canvas images, their loading and rendering depend entirely on how users structure and style their sketches, making lazy loading less applicable in this context.

For other components, if we identify parts of the Web Editor that could benefit from lazy loading, we should first determine whether those components belong in the Web Editor repository or if they are better suited for the main p5.js repository. It might be more effective to discuss potential performance improvements in the broader scope of p5.js itself.
Would love to hear thoughts and opinions on this.

@shivasankaran18
Copy link
Author

hello @Jatin24062005 , I understand that there isn't a specific image component that could benefit from lazy loading. However, lazy loading can still be applied to other React components within the Web Editor.
We should identify specific React components within the Web Editor that could benefit from lazy loading. This could include components that are not needed during the initial load but are used later during user interactions.

I would love to hear your thoughts on this.. @Jatin24062005 @raclim

@yashodipmore
Copy link

Hi,
@shivasankaran18
I noticed that the processing/p5.js-web-editor repository does not currently implement lazy loading for React components. Adding lazy loading can significantly improve the performance of the web editor by reducing the initial load time and loading components only when required.

I’d love to work on this enhancement. Could you please assign this issue to me?

Looking forward to your response!

@shivasankaran18
Copy link
Author

@yashodipmore I am working in this issue

@shivasankaran18 shivasankaran18 linked a pull request Mar 26, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants