Skip to content

Fixes/remove package lock #3429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes/remove package lock #3429

wants to merge 2 commits into from

Conversation

StrTux
Copy link

@StrTux StrTux commented Apr 5, 2025 •
edited by raclim
Loading

Description

This PR removes package-lock.json from version control by adding it to .gitignore to prevent npm installation issues across different development environments. This change addresses the following problems:

  • Node version compatibility conflicts during npm install
  • Package dependency conflicts due to mismatched lockfile versions
  • Installation failures for contributors using different Node versions

Changes Made

  1. Added package-lock.json to .gitignore to prevent it from being tracked in version control
  2. This allows each developer's environment to generate its own compatible lockfile

Benefits

  • Cleaner npm installations for new contributors
  • Reduced setup issues across different Node.js versions
  • More flexible dependency resolution during development

Testing

  • Verified clean npm install on a fresh clone
  • No linting errors (npm run lint)
  • All tests passing (npm run test)

Fixes #3430

@welcome Welcome
Copy link

welcome bot commented Apr 5, 2025

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@raclim
Copy link
Collaborator

raclim commented Apr 5, 2025 •
edited
Loading

Hi, thanks for taking the time to open this!

Deleting package-lock.json is generally not recommended, especially for open source projects, because it ensures that everyone is able to install their project and all of its dependencies deterministically, or with the exact same version numbers. If this file is deleted, the required package setup can shift over time because of version ranges (i.e a package can have a range like ^1.2.3), which can cause folks to have inconsistent environments.

Due to these reasons I'm going to close this PR, but we can try to figure out what might be happening in your setup process in the linked issue.

@raclim raclim closed this Apr 5, 2025
@raclim raclim mentioned this pull request Apr 5, 2025
Open
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm install fails due to package-lock.json – suggest removal to fix node issues
2 participants
@StrTux @raclim