Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate all examples in DOM to Chinese #772

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MuyingLi
Copy link
Contributor

@MuyingLi MuyingLi commented May 4, 2020

Addresses #[646]

Changes:
translated all examples in DOM to Chinese

* @description 你需要在该范例中包含
* <a href="http://p5js.org/reference/#/libraries/p5.dom"> p5.dom 库</a>
* 才能在你自己的项目中使用。<br><br>
* 滑动滑杆来控制背景的 R, G, B 值。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @MuyingLi thank you!
on @description, please replace it with only

  • @description 滑动滑杆来控制背景的 R, G, B 值。
    and delete these lines
    你需要在该范例中包含
  • p5.dom 库
  • 才能在你自己的项目中使用。

p5.dom.js is a library that is now part of p5.js, so we don't need that first part. thank you!

Copy link
Member

@montoyamoraga montoyamoraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tagged all the mentions to p5.dom.js that should be deleted
thank you so much @MuyingLi :)

* @frame 710,300
* @description Create DOM elements and modify their properties every time
* draw() is called.
* @description <p>你需要在该范例中包含
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MuyingLi same i mentioned above,
please only translate the description, and not add the old reference to p5.dom :)

* @frame 710,250
* @description Load a video with multiple formats and toggle between playing
* and paused with a button press.
* @description <p>加载多种格式的视频并通过按钮来控制播放与暂停。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

* @name 视频画布
* @description <p>加载多种格式的视频并绘制到画布。</p>
* <p><em><span class="small"> 要在本地运行此范例,你需要至少一个视频文件和
* <a href="http://p5js.org/reference/#/libraries/p5.dom"> p5.dom 库,</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

* @description Load a video, manipulate its pixels and draw to canvas.
* To run this example locally, you will need a running
* <a href="https://github.com/processing/p5.js/wiki/Local-server">local server</a>.
* @description <p>加载一个视频,操纵其像素并绘制到画布上。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

* 从网络摄像头中捕捉视频,并在画布上加上反向滤镜显示出来。
* 请注意:在默认情况下,捕捉文件也会显示出来。你可以取消 capture.hide() 那行的注释来隐藏文件。<br><br>
* <em><span class="small"> 要在本地运行此范例,你需要至少一个视频文件和
* <a href="http://p5js.org/reference/#/libraries/p5.dom">p5.dom 库,</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

* @description Drag an image file onto the canvas to see it displayed.
* @name 拖放图片 (Drop)
* @description 你需要在该范例中包含
* <a href="http://p5js.org/reference/#/libraries/p5.dom"> p5.dom 库</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here :)

* @description Input text and click the button to see it affect the the canvas.
* @name 输入框和按钮
* @description 你需要在该范例中包含
* <a href="http://p5js.org/reference/#/libraries/p5.dom"> p5.dom 库</a>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Member

@montoyamoraga montoyamoraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ugh sorry, i first reviewed and clicked on "approve", i meant "request changes" :)

Copy link
Member

@limzykenneth limzykenneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments. There are some <p> tags scattered throughout as well, if you can remove those that would be great. Thanks!

* @description <p>你需要在该范例中包含
* <a href="http://p5js.org/reference/#/libraries/p5.dom"> p5.dom 库</a>
* 才能在你自己的项目中使用。<br><br>
* 每次调用 draw() 函数时,创建 DOM 元素并修改其属性。</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit confusing. The element is only created once and in every draw() it is modified. The wording here's feels like in every draw() and element is created then modified.

Comment on lines +27 to +28
// 该段落是在主要代码旁创建的。
// 为了区分创建元素和选择元素。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly reword these two sentences. The original is kinda confusing as well so you can rewrite this altogether. The gist is to say that createP() here is to say that one can create an element in p5.js then select it or as below can just be pure HTML before being selected.

Comment on lines 31 to 32
'I learn in this Letter, that Don Peter of Aragon, ' +
' comes this night to Messina'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can insert a custom Chinese text here if you want. Doesn't need to be a translation of this sentence.

@lmccart lmccart changed the base branch from master to main June 14, 2020 20:57
@lmccart
Copy link
Member

lmccart commented Jan 4, 2021

@MuyingLi are you still interested in working on this pull request?

@lmccart
Copy link
Member

lmccart commented Mar 13, 2021

@limzykenneth would you suggest we close this PR?

@limzykenneth
Copy link
Member

This is a bit stale now and would require some work to get it ready for merge. It is a bit of a shame to close as is because most of the translations here are good. I can put it on my list of things to do when I get some free time but it's a long list. I guess we can close it for now and maybe revisit with commits in this PR as a starting point.

@lmccart
Copy link
Member

lmccart commented Mar 13, 2021

Well no harm to leave it open for now I think. If anyone wants to come finish it up we can merge. We also have translation projects on our list for GSOC so if anyone proposed to continue work on this translation, we can ask them to take a look at this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants