Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line numbers need more contrast #994

Open
babaissarkar opened this issue Mar 21, 2025 · 1 comment · May be fixed by #1000
Open

Line numbers need more contrast #994

babaissarkar opened this issue Mar 21, 2025 · 1 comment · May be fixed by #1000
Assignees

Comments

@babaissarkar
Copy link

The line numbers are not very readable in most themes. Possibly they need more font weight or a contrasting color.

Image

Version: latest checkout of #988. (694eb0c) Should be reproducible in master as well.

@SableRaf
Copy link
Collaborator

Thanks @babaissarkar for your attention to detail!

This is a known and widespread issue across most themes as you've correctly noted. In fact, contrast is an issue with some of the syntax highlighting palettes too.

Note that the way themes are implemented is not exactly ideal in its current state (@Stefterv can tell you more) and refactoring it to use Jetpack Compose is part of our long term roadmap.

However, since this is a matter of accessibility, it might still be worth fixing in the legacy system. Feel free to give it a go.

@babaissarkar babaissarkar linked a pull request Mar 23, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants